Use entry Assembly for telemetry version, always learn when learn=true#1122
Merged
alzimmermsft merged 5 commits intomicrosoft:mainfrom Nov 10, 2025
Merged
Use entry Assembly for telemetry version, always learn when learn=true#1122alzimmermsft merged 5 commits intomicrosoft:mainfrom
alzimmermsft merged 5 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses two bugs in the Azure MCP Core:
- Corrects telemetry version reporting by using the entry assembly instead of the calling assembly
- Fixes namespace mode learning to respect the
learn=trueflag regardless of whether a command is specified
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| core/Azure.Mcp.Core/src/Extensions/OpenTelemetryExtensions.cs | Changed GetServerVersion to SetServerVersion, switched from GetCallingAssembly() to GetEntryAssembly() for accurate version telemetry, and added null safety check |
| core/Azure.Mcp.Core/src/Areas/Server/Commands/ToolLoading/NamespaceToolLoader.cs | Removed condition that prevented learning when a command was specified, ensuring learn=true always triggers learning mode |
conniey
reviewed
Nov 10, 2025
conniey
reviewed
Nov 10, 2025
conniey
approved these changes
Nov 10, 2025
conniey
reviewed
Nov 10, 2025
conniey
approved these changes
Nov 10, 2025
conniey
approved these changes
Nov 10, 2025
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Dec 8, 2025
microsoft#1122) * Use entry Assembly for telemetry version, always learn when learn=true * Add CHANGELOG entry * PR feedback * One small fix * Fix code-docs mismatch
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Two small fixes:
Assemblywas being used to setVersionin telemetry. This has been corrected to the entryAssembly, which will now produce the correctVersionfor telemetry.--mode namespacestill had a path wherelearn=truewouldn't result in learning happening.GitHub issue number?
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline