Skip to content

Default HTTPS redirection for remote MCP server with opt-out env var.#1169

Merged
kvenkatrajan merged 1 commit intomainfrom
users/vukelich/httpsredirect
Nov 14, 2025
Merged

Default HTTPS redirection for remote MCP server with opt-out env var.#1169
kvenkatrajan merged 1 commit intomainfrom
users/vukelich/httpsredirect

Conversation

@vukelich
Copy link
Copy Markdown
Member

@vukelich vukelich commented Nov 13, 2025

What does this PR do?

[Provide a clear, concise description of the changes]
Use app.UseHttpsRedirection() within the remote MCP server middleware unless opt-ed out with AZURE_MCP_DANGEROUSLY_DISABLE_HTTPS_REDIRECTION

[Any additional context, screenshots, or information that helps reviewers]

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes using script at eng/scripts/Process-PackageReadMe.ps1. See Package README
    • Updated command list in /servers/Azure.Mcp.Server/docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • Run .\eng\scripts\Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds default HTTPS redirection to the remote MCP server with an opt-out mechanism via the AZURE_MCP_DISABLE_HTTPS_REDIRECTION environment variable. This enhances security by ensuring HTTPS is used by default unless explicitly disabled.

Key Changes:

  • Added HTTPS redirection middleware in CreateHttpHost() that activates by default
  • Introduced AZURE_MCP_DISABLE_HTTPS_REDIRECTION environment variable to allow opt-out for scenarios like reverse proxy deployments or local development

Comment thread core/Azure.Mcp.Core/src/Areas/Server/Commands/ServiceStartCommand.cs Outdated
Comment thread core/Azure.Mcp.Core/src/Areas/Server/Commands/ServiceStartCommand.cs Outdated
Comment thread core/Azure.Mcp.Core/src/Areas/Server/Commands/ServiceStartCommand.cs Outdated
Comment thread servers/Azure.Mcp.Server/CHANGELOG.md Outdated
@github-project-automation github-project-automation Bot moved this from Untriaged to In Progress in Azure MCP Server Nov 13, 2025
Comment thread core/Azure.Mcp.Core/src/Areas/Server/Commands/ServiceStartCommand.cs Outdated
@vukelich vukelich force-pushed the users/vukelich/httpsredirect branch from a7e58ba to 5aa7704 Compare November 14, 2025 17:59
@kvenkatrajan kvenkatrajan merged commit 71f5455 into main Nov 14, 2025
26 checks passed
@kvenkatrajan kvenkatrajan deleted the users/vukelich/httpsredirect branch November 14, 2025 22:07
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Azure MCP Server Nov 14, 2025
colbytimm pushed a commit to colbytimm/microsoft-mcp that referenced this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants