fix: move ai best practice into best practice namespace#1323
fix: move ai best practice into best practice namespace#1323fanyang-mono merged 4 commits intomicrosoft:mainfrom
Conversation
2c196c2 to
a498fc4
Compare
There was a problem hiding this comment.
Pull request overview
This PR consolidates AI application best practices guidance by moving the AIAppBestPracticesCommand from a standalone Azure.Mcp.Tools.AzureAIBestPractices tool into the existing Azure.Mcp.Tools.AzureBestPractices namespace as a subcommand. This refactoring improves organization by grouping all Azure best practices under a single tool.
Key changes:
- Moved AI app best practices command from separate tool to
AzureBestPracticesasai_appsubcommand - Removed entire
Azure.Mcp.Tools.AzureAIBestPracticesproject and references - Updated command name from
azureaibestpractices_gettoget_bestpractices_ai_app
Reviewed changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.AzureBestPractices/src/Commands/AIAppBestPracticesCommand.cs | Added AI app best practices command to AzureBestPractices namespace with updated naming (ai_app) |
| tools/Azure.Mcp.Tools.AzureBestPractices/src/AzureBestPracticesSetup.cs | Registered AIAppBestPracticesCommand as a subcommand under the bestpractices command group |
| tools/Azure.Mcp.Tools.AzureBestPractices/src/Resources/*.txt | Moved AI-related resource files (ai-best-practices-core.txt, ai-background-knowledge.txt, ai-error-patterns.txt) with minor content updates |
| tools/Azure.Mcp.Tools.AzureBestPractices/tests/Azure.Mcp.Tools.AzureBestPractices.UnitTests/AIAppBestPracticesCommandTests.cs | Added comprehensive unit tests for the new AI app best practices command |
| tools/Azure.Mcp.Tools.AzureAIBestPractices/src/*.cs | Removed old standalone tool source files |
| tools/Azure.Mcp.Tools.AzureAIBestPractices/tests/**/*.cs | Removed old test files from standalone tool |
| servers/Azure.Mcp.Server/src/Program.cs | Removed AzureAIBestPracticesSetup registration from server startup |
| servers/Azure.Mcp.Server/docs/azmcp-commands.md | Updated command documentation to reflect new command location under bestpractices |
| servers/Azure.Mcp.Server/docs/e2eTestPrompts.md | Moved test prompts from Azure AI Best Practices section to Azure Best Practices section |
| servers/Azure.Mcp.Server/README.md | Removed Azure AI Best Practices from service areas list |
| core/Azure.Mcp.Core/src/Areas/Server/Resources/azure-rules.txt | Updated rule to reference new command name get_bestpractices_ai_app |
| AzureMcp.sln | Removed AzureAIBestPractices project references |
| .github/CODEOWNERS | Updated code ownership to add @XiaofuHuang to AzureBestPractices tool |
core/Azure.Mcp.Core/src/Areas/Server/Resources/consolidated-tools.json- Line 1013 still referencesazureaibestpractices_getand should be updated toget_bestpractices_ai_appeng/tools/ToolDescriptionEvaluator/prompts/prompts.json- The keyazureaibestpractices_getshould be renamed toget_bestpractices_ai_app
These files are required to be updated according to the PR checklist item: "For tools with new names, including new tools or renamed tools, update consolidated-tools.json".
Comments suppressed due to low confidence (1)
servers/Azure.Mcp.Server/src/Program.cs:222
- Incorrect indentation: This line should be indented with 8 spaces to align with the statement above (line 221), but it currently has only 4 spaces of indentation.
await telemetryService.InitializeAsync();
d51ec38 to
08a5d30
Compare
08a5d30 to
6c0bb32
Compare
|
/azp run mcp - pullrequest - live |
|
Azure Pipelines successfully started running 1 pipeline(s). |
fanyang-mono
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the fix!
* fix: move ai best practice into best practice namespace * fix: avoid misunderstandings of azure best practice and ai best practice * refactor: remove empty lines in namespace description * fix: Updated the rule to clearly specify when to call ai best practice
* fix: move ai best practice into best practice namespace * fix: avoid misunderstandings of azure best practice and ai best practice * refactor: remove empty lines in namespace description * fix: Updated the rule to clearly specify when to call ai best practice
* fix: move ai best practice into best practice namespace * fix: avoid misunderstandings of azure best practice and ai best practice * refactor: remove empty lines in namespace description * fix: Updated the rule to clearly specify when to call ai best practice
What does this PR do?
Move Azure AI best practice tool into best practice namespace
GitHub issue number?
#1110
Contributes to #1265
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.json/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline