Skip to content

Conversation

@ankushbindlish2
Copy link
Member

Revised Azure FileShares test prompts to use resource group and location parameters instead of storage account, and updated prompt wording for consistency and clarity.

What does this PR do?

[Provide a clear, concise description of the changes]

[Any additional context, screenshots, or information that helps reviewers]

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes using script at eng/scripts/Process-PackageReadMe.ps1. See Package README
    • Updated command list in /servers/Azure.Mcp.Server/docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • Run .\eng\scripts\Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

Revised Azure FileShares test prompts to use resource group and location parameters instead of storage account, and updated prompt wording for consistency and clarity.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Azure FileShares e2e test prompts to align with the actual API parameters used by the FileShares tools. The changes replace references to storage accounts with resource groups and locations, which accurately reflects how the FileShares API operates.

Changes:

  • Updated all FileShares test prompts to use resource group and location parameters instead of storage account references
  • Revised prompt wording for consistency (e.g., "provisioned storage" instead of "quota", "media tier" instead of "access tier")
  • Fixed section heading from "Azure File Shares" to "Azure FileShares" for consistency

Comment on lines +301 to 303
| fileshares_fileshare_provisioningrecommendation_get | Get provisioning recommendations for file share <file_share_name> in resource group <resource_group_name> |
| fileshares_fileshare_provisioningrecommendation_get | Show me provisioning recommendations for file share <file_share_name> |
| fileshares_fileshare_provisioningrecommendation_get | What are the recommended provisioning settings for file share <file_share_name>? |
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fileshares_fileshare_provisioningrecommendation_get command requires a location parameter, not a resource group. According to the command implementation (FileShareGetProvisioningRecommendationCommand), this command takes subscription and location as required parameters and provides recommendations based on storage size, not for a specific existing file share. The test prompt should be: 'Get provisioning recommendations for location with GB storage' or similar.

Suggested change
| fileshares_fileshare_provisioningrecommendation_get | Get provisioning recommendations for file share <file_share_name> in resource group <resource_group_name> |
| fileshares_fileshare_provisioningrecommendation_get | Show me provisioning recommendations for file share <file_share_name> |
| fileshares_fileshare_provisioningrecommendation_get | What are the recommended provisioning settings for file share <file_share_name>? |
| fileshares_fileshare_provisioningrecommendation_get | Get provisioning recommendations for location <location> with <size> GB storage in subscription <subscription> |
| fileshares_fileshare_provisioningrecommendation_get | Show me provisioning recommendations in location <location> for <size> GB of file share storage |
| fileshares_fileshare_provisioningrecommendation_get | What are the recommended provisioning settings in location <location> for <size> GB of file share capacity? |

Copilot uses AI. Check for mistakes.
Comment on lines +318 to 320
| fileshares_fileshare_usage_get | Get usage data for file share <file_share_name> in resource group <resource_group_name> |
| fileshares_fileshare_usage_get | Show me the usage statistics for file share <file_share_name> |
| fileshares_fileshare_usage_get | What is the current usage of file share <file_share_name>? |
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fileshares_fileshare_usage_get command requires a location parameter at the subscription level, not a specific file share or resource group. According to FileShareGetUsageDataCommand, it takes only subscription and location parameters to get usage data for a region. The test prompt should reference location instead: 'Get usage data for file shares in location ' or similar.

Suggested change
| fileshares_fileshare_usage_get | Get usage data for file share <file_share_name> in resource group <resource_group_name> |
| fileshares_fileshare_usage_get | Show me the usage statistics for file share <file_share_name> |
| fileshares_fileshare_usage_get | What is the current usage of file share <file_share_name>? |
| fileshares_fileshare_usage_get | Get usage data for file shares in location <location> |
| fileshares_fileshare_usage_get | Show me the usage statistics for file shares in location <location> |
| fileshares_fileshare_usage_get | What is the current file share usage in location <location>? |

Copilot uses AI. Check for mistakes.
| fileshares_fileshare_usage_get | Get usage data for file share <file_share_name> in storage account <account_name> |
| fileshares_fileshare_update | Update file share <file_share_name> in resource group <resource_group_name> |
| fileshares_fileshare_update | Update the provisioned storage for file share <file_share_name> to 200 GB |
| fileshares_fileshare_update | Change the media tier of file share <file_share_name> to Standard |
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The media tier values for FileShares are 'SSD' or 'HDD' according to the FileShareCreateCommand implementation, not 'Standard'. The test prompt should use a valid media tier value like 'SSD' or 'HDD'.

Suggested change
| fileshares_fileshare_update | Change the media tier of file share <file_share_name> to Standard |
| fileshares_fileshare_update | Change the media tier of file share <file_share_name> to SSD |

Copilot uses AI. Check for mistakes.
@github-project-automation github-project-automation bot moved this from Untriaged to In Progress in Azure MCP Server Jan 16, 2026
@g2vinay g2vinay merged commit a376af5 into main Jan 16, 2026
40 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure MCP Server Jan 16, 2026
@g2vinay g2vinay deleted the fileshares-prompt-updates branch January 16, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants