Remove last usage of ErrorDetails in telemetry#1625
Merged
alzimmermsft merged 3 commits intomicrosoft:mainfrom Feb 3, 2026
Merged
Remove last usage of ErrorDetails in telemetry#1625alzimmermsft merged 3 commits intomicrosoft:mainfrom
alzimmermsft merged 3 commits intomicrosoft:mainfrom
Conversation
alzimmermsft
requested review from
JonathanCrd,
conniey,
fanyang-mono,
jairmyree,
jongio,
vukelich and
wbreza
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the last remaining generic capture of ErrorDetails into telemetry when tool execution returns an error result.
Changes:
- Deletes the fallback logic that extracts the first
TextContentBlockfrom an errorCallToolResultand emits it asTagName.ErrorDetails. - Leaves error status reporting intact via
activity?.SetStatus(ActivityStatusCode.Error).
joshfree
approved these changes
Feb 2, 2026
Member
joshfree
left a comment
joshfree
left a comment
There was a problem hiding this comment.
Should the ErrorDetails be logged locally instead of a telemetry event?
github-project-automation
Bot
moved this from Untriaged
to In Progress
in Azure MCP Server
joshfree
reviewed
Feb 2, 2026
Contributor
Author
Given we're using the SDKs under the hood for this, outside MCP specific code such as args parsing, etc, we probably should provide guidance on configuring SDK logging to capture this. |
conniey
approved these changes
Feb 3, 2026
20 tasks
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Apr 20, 2026
* Remove last usage of ErrorDetails in telemetry * Changelog entry * Simplify changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes last generic capture of
ErrorDetailsin telemetry.GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.json/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline