Add Cancellation Token Usage To Deploy Tool#1627
Merged
Conversation
msalaman
changed the title
msalaman
requested review from
JasonYeMSFT,
chidozieononiwu,
Copilot,
jongio,
joshfree,
saikoumudi,
tmeschter and
xiangyan99
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the deploy tool's cancellation support by threading CancellationToken parameters through the static methods and async operations involved in retrieving Azure deployment logs.
Changes:
- Added
CancellationTokenparameter to theGetAzdResourceLogsAsyncmethod and propagated it through the call chain - Updated
AzdAppLogRetrievermethods to accept and useCancellationTokenin all async Azure SDK operations - Ensured cancellation tokens are passed to Azure Resource Manager and Logs Query Client operations
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.Deploy/src/Services/DeployService.cs | Passes cancellation token to GetAzdResourceLogsAsync |
| tools/Azure.Mcp.Tools.Deploy/src/Services/Util/AzdResourceLogService.cs | Adds cancellation token parameter and propagates it to initialization and query methods |
| tools/Azure.Mcp.Tools.Deploy/src/Services/Util/AzdAppLogRetriever.cs | Updates all async methods to accept and use cancellation tokens in Azure SDK calls |
vukelich
requested changes
Feb 3, 2026
Member
vukelich
left a comment
vukelich
left a comment
There was a problem hiding this comment.
Small suggestions for conventions.
github-project-automation
Bot
moved this from Untriaged
to In Progress
in Azure MCP Server
vukelich
requested changes
Feb 3, 2026
Member
vukelich
left a comment
vukelich
left a comment
There was a problem hiding this comment.
Couple more cases of IAsyncEnumerable needing CancellationToken
vukelich
approved these changes
Feb 3, 2026
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Apr 20, 2026
* add cancellation token parameters * cleaned up some changes * fixed more changes * update cancellation token logic * update to only apply cancellation tokens were needed * removed default * debugged changes * merge with main * removed extra file * update parameter position * update parameters * use cancellation token
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add cancellation token usage to static methods used by the deploy tool
GitHub issue number?
#1583
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.json/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline