Merged
Conversation
alzimmermsft
approved these changes
Feb 3, 2026
anuchandy
reviewed
Feb 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds URL validation to ResourceHealth and Kusto tools to prevent Server-Side Request Forgery (SSRF) attacks. The changes validate user-provided URLs/resource IDs before using them in HTTP requests.
Changes:
- Added comprehensive validation for Azure Resource IDs in ResourceHealth using
Azure.Core.ResourceIdentifier.Parse() - Added domain suffix and hostname allowlist validation for Kusto cluster URIs across multiple Azure clouds
- Included extensive unit tests covering malicious inputs, edge cases, and valid scenarios
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.ResourceHealth/tests/Azure.Mcp.Tools.ResourceHealth.UnitTests/Services/ResourceHealthServiceSsrfValidationTests.cs | New test file with 183 lines of comprehensive SSRF protection tests for ResourceHealth service |
| tools/Azure.Mcp.Tools.ResourceHealth/src/Services/ResourceHealthService.cs | Updated to validate resource IDs using Azure SDK and construct URLs safely with Uri class |
| tools/Azure.Mcp.Tools.Kusto/tests/Azure.Mcp.Tools.Kusto.UnitTests/KustoClientTests.cs | Added 149 lines of SSRF protection tests for Kusto client validation |
| tools/Azure.Mcp.Tools.Kusto/src/Services/KustoClient.cs | Added cluster URI validation with domain suffix allowlist and hostname segment validation |
| tools/Azure.Mcp.Tools.Kusto/tests/Azure.Mcp.Tools.Kusto.LiveTests/assets.json | Updated Tag field for recorded test assets |
| servers/Azure.Mcp.Server/changelog-entries/input-validation-improvements.yaml | Added changelog entry documenting the security improvements |
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Apr 20, 2026
* add url validations * update recordings. * update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[Provide a clear, concise description of the changes]add url validations for ResourceHealth & kusto tools
[Any additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.json/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline