Skip to content

Update tests for new .NET version and fix ServiceFabricCommandTests#1748

Merged
vcolin7 merged 3 commits intomainfrom
vcolin7/fix-live-tests
Feb 18, 2026
Merged

Update tests for new .NET version and fix ServiceFabricCommandTests#1748
vcolin7 merged 3 commits intomainfrom
vcolin7/fix-live-tests

Conversation

@vcolin7
Copy link
Contributor

@vcolin7 vcolin7 commented Feb 18, 2026

What does this PR do?

Update Test-Code.ps1 to accommodate the new .NET version by handling solution file creation correctly. Fix issues in ServiceFabricCommandTests to ensure successful execution of tests.

Update a recorded test for Compute- it was earlier comparing the SKU Name of the VMs, but VMs can differ between environments, and not all regions have the same availability for the same SKU etc. So, instead of doing a literal string comparison, we can just check that the property is not null.

GitHub issue number?

N/A

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes using script at eng/scripts/Process-PackageReadMe.ps1. See Package README
    • Updated command list in /servers/Azure.Mcp.Server/docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • Run .\eng\scripts\Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates test infrastructure to work with newer .NET SDK solution formats and fixes Service Fabric live/recorded test setup so tests execute successfully in the repo’s recorded-test framework.

Changes:

  • Update Test-Code.ps1 to locate the generated temporary solution file regardless of .sln vs .slnx.
  • Fix ServiceFabricCommandTests constructor to include LiveServerFixture and pass it to RecordedCommandTestsBase.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tools/Azure.Mcp.Tools.ServiceFabric/tests/Azure.Mcp.Tools.ServiceFabric.LiveTests/ServiceFabricCommandTests.cs Aligns Service Fabric tests with RecordedCommandTestsBase fixture requirements by including LiveServerFixture.
eng/scripts/Test-Code.ps1 Makes temporary solution detection resilient to .sln/.slnx output from newer .NET SDKs.

@anannya03 anannya03 requested a review from g2vinay as a code owner February 18, 2026 06:34
@vcolin7 vcolin7 merged commit 1812f79 into main Feb 18, 2026
16 checks passed
@vcolin7 vcolin7 deleted the vcolin7/fix-live-tests branch February 18, 2026 17:19
@github-project-automation github-project-automation bot moved this from Untriaged to Done in Azure MCP Server Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools-ServiceFabric Service Fabric

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants

Comments