Move azure resource files out of Microsoft.Mcp.Core#1827
Merged
hallipr merged 5 commits intomicrosoft:mainfrom Mar 3, 2026
Merged
Move azure resource files out of Microsoft.Mcp.Core#1827hallipr merged 5 commits intomicrosoft:mainfrom
hallipr merged 5 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Moves Azure-specific embedded resources out of the shared core library and updates server startup to explicitly register resources/providers at program initialization.
Changes:
- Updates registry discovery to load
registry.jsonfrom a specified assembly/resource instead of scanning the executing assembly. - Introduces pluggable providers for server instructions and consolidated tool definitions (including null/default implementations).
- Updates Azure/Fabric/Template servers to register the new providers and (for Azure) embed and load resource files from the server assembly.
Reviewed changes
Copilot reviewed 17 out of 20 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| servers/Template.Mcp.Server/src/Program.cs | Registers default/empty registry + instruction/tool providers for the template server |
| servers/Fabric.Mcp.Server/src/Program.cs | Switches Fabric server to an explicit empty registry + null providers |
| servers/Azure.Mcp.Server/src/Properties/AssemblyInfo.cs | Exposes Azure server internals to unit tests |
| servers/Azure.Mcp.Server/src/Program.cs | Loads registry/instructions/tools from Azure server embedded resources |
| servers/Azure.Mcp.Server/src/Azure.Mcp.Server.csproj | Embeds server Resources/*.* into Azure server assembly |
| core/Microsoft.Mcp.Core/src/Helpers/RegistryServerHelper.cs | Changes registry loading helper to accept assembly + resource name |
| core/Microsoft.Mcp.Core/src/Areas/Server/RegistryServerServiceCollectionExtensions.cs | Updates AddRegistryRoot to accept assembly + resource name |
| core/Microsoft.Mcp.Core/src/Areas/Server/Commands/ServiceCollectionExtensions.cs | Injects IServerInstructionsProvider and removes embedded-resource instruction loading from core |
| core/Microsoft.Mcp.Core/src/Areas/Server/Commands/ServerInstructions/ResourceServerInstructionsProvider.cs | Adds provider for loading instructions from embedded resources |
| core/Microsoft.Mcp.Core/src/Areas/Server/Commands/ServerInstructions/NullServerInstructionsProvider.cs | Adds null provider for server instructions |
| core/Microsoft.Mcp.Core/src/Areas/Server/Commands/ServerInstructions/IServerInstructionsProvider.cs | Adds interface contract for server instructions |
| core/Microsoft.Mcp.Core/src/Areas/Server/Commands/Discovery/IConsolidatedToolDefinitionProvider.cs | Adds consolidated tool definition provider + implementations |
| core/Microsoft.Mcp.Core/src/Areas/Server/Commands/Discovery/ConsolidatedToolDiscoveryStrategy.cs | Switches consolidated tool loading to use injected provider |
| core/Azure.Mcp.Core/tests/Azure.Mcp.Core.UnitTests/RegistryDiscoveryStrategyHelper.cs | Updates tests to load registry from Azure server embedded resource |
| core/Azure.Mcp.Core/tests/Azure.Mcp.Core.UnitTests/Areas/Server/Commands/ToolLoading/SingleProxyToolLoaderTests.cs | Updates tests to load registry from Azure server embedded resource |
| core/Azure.Mcp.Core/tests/Azure.Mcp.Core.UnitTests/Areas/Server/Commands/ServiceCollectionExtensionsTests.cs | Updates tests to use new AddRegistryRoot(assembly, resource) signature |
| core/Azure.Mcp.Core/tests/Azure.Mcp.Core.UnitTests/Areas/Server/Commands/Discovery/ConsolidatedToolDiscoveryStrategyTests.cs | Updates tests to provide an IConsolidatedToolDefinitionProvider |
055bf75 to
5827430
Compare
a1c0b05 to
ad7f35c
Compare
Member
Author
|
/azp run mcp - pullrequest - live |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AmosHersch
approved these changes
Mar 3, 2026
ad7f35c to
5c9f13b
Compare
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
GitHub issue number?
partially addresses #289
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.json/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline