Skip to content

List all resources in a Resource Group#1975

Merged
ArthurMa1978 merged 15 commits intomainfrom
copilot/implement-generic-resource-azure
Mar 20, 2026
Merged

List all resources in a Resource Group#1975
ArthurMa1978 merged 15 commits intomainfrom
copilot/implement-generic-resource-azure

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 9, 2026

  • Analyze all unresolved PR review comments
  • Rename GroupResourceListCommand to ResourceListCommand (alzimmermsft)
  • Inject IResourceGroupService via constructor instead of context.GetService<>() (conniey)
  • Change GetGenericResources to return IAsyncEnumerable (conniey)
  • Remove catch-and-rethrow in ResourceGroupService.GetGenericResources (alzimmermsft)
  • Update GroupJsonContext.cs, GroupSetup.cs, and test files to match
  • Fix CI: register IResourceGroupService mock in CommandFactoryHelpers.SetupCommonServices()
  • Verify all tests pass (812 pass, 1 unrelated network test skipped)
  • Resolve merge conflict with main in CommandFactoryHelpers.cs — kept both IResourceGroupService mock (from our branch) and new service mocks from main (IDateTimeProvider, IExternalProcessService, IAzureTokenCredentialProvider, IAzureCloudConfiguration)

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

…roup using GenericResource API

Co-authored-by: ArthurMa1978 <20514459+ArthurMa1978@users.noreply.github.com>
Copilot AI changed the title [WIP] Implement Azure.ResourceManager GenericResource for issue 1631 Add group resource list command using GenericResource API Mar 10, 2026
Copilot AI and others added 3 commits March 10, 2026 07:37
Co-authored-by: ArthurMa1978 <20514459+ArthurMa1978@users.noreply.github.com>
…up_resource_list tool

Co-authored-by: ArthurMa1978 <20514459+ArthurMa1978@users.noreply.github.com>
Co-authored-by: ArthurMa1978 <20514459+ArthurMa1978@users.noreply.github.com>
Copilot AI changed the title Add group resource list command using GenericResource API Fix ServerStartCommandTests tool count assertions for group_resource_list Mar 10, 2026
…lt type

- Revert GroupListCommand.cs to match main (no modification needed)
- Rename GroupResourceListCommand.Result to GroupResourceListCommandResult
  to follow the established naming convention (e.g. AccountCreateCommandResult)
- Update GroupJsonContext to remove TypeInfoPropertyName workaround

Co-authored-by: ArthurMa1978 <20514459+ArthurMa1978@users.noreply.github.com>
Copilot AI changed the title Fix ServerStartCommandTests tool count assertions for group_resource_list Fix CI: revert GroupListCommand modification, follow Result naming convention Mar 10, 2026
@ArthurMa1978 ArthurMa1978 marked this pull request as ready for review March 11, 2026 03:33
@ArthurMa1978 ArthurMa1978 requested review from a team as code owners March 11, 2026 03:33
…ourceGroupService.GetGenericResources

Co-authored-by: ArthurMa1978 <20514459+ArthurMa1978@users.noreply.github.com>
@ArthurMa1978 ArthurMa1978 changed the title Fix CI: revert GroupListCommand modification, follow Result naming convention List all resources in a Resource Group Mar 16, 2026
Comment thread core/Azure.Mcp.Core/src/Areas/Group/Commands/ResourceListCommand.cs
Comment thread core/Azure.Mcp.Core/src/Services/Azure/ResourceGroup/IResourceGroupService.cs Outdated
@github-project-automation github-project-automation Bot moved this from Untriaged to In Progress in Azure MCP Server Mar 16, 2026
Comment thread core/Azure.Mcp.Core/src/Areas/Group/Commands/GroupResourceListCommand.cs Outdated
Comment thread core/Azure.Mcp.Core/src/Areas/Group/Commands/GroupResourceListCommand.cs Outdated
Comment thread core/Azure.Mcp.Core/src/Services/Azure/ResourceGroup/ResourceGroupService.cs Outdated
ArthurMa1978 and others added 3 commits March 17, 2026 16:48
…Command.cs

Co-authored-by: Alan Zimmer <48699787+alzimmermsft@users.noreply.github.com>
…/UnitTests/GroupResourceListCommandTests.cs

Co-authored-by: Alan Zimmer <48699787+alzimmermsft@users.noreply.github.com>
…/UnitTests/GroupResourceListCommandTests.cs

Co-authored-by: Alan Zimmer <48699787+alzimmermsft@users.noreply.github.com>
…Enumerable, remove catch-rethrow

Co-authored-by: ArthurMa1978 <20514459+ArthurMa1978@users.noreply.github.com>
Copilot AI and others added 2 commits March 17, 2026 09:37
Co-authored-by: ArthurMa1978 <20514459+ArthurMa1978@users.noreply.github.com>
…and revert global.json

Co-authored-by: ArthurMa1978 <20514459+ArthurMa1978@users.noreply.github.com>
…eric-resource-azure

# Conflicts:
#	core/Azure.Mcp.Core/tests/Azure.Mcp.Core.UnitTests/Areas/Server/CommandFactoryHelpers.cs
@ArthurMa1978 ArthurMa1978 merged commit 66e5fd2 into main Mar 20, 2026
16 checks passed
@ArthurMa1978 ArthurMa1978 deleted the copilot/implement-generic-resource-azure branch March 20, 2026 03:27
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Azure MCP Server Mar 20, 2026
colbytimm pushed a commit to colbytimm/microsoft-mcp that referenced this pull request Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Feature request / Question] List all resources in a Resource Group via Azure MCP Server

6 participants