Revert: address feedback on wellarchitectedframework_serviceguide_list command#2021
Closed
Copilot wants to merge 3 commits intousers/skakara/waf-service-listfrom
Closed
Revert: address feedback on wellarchitectedframework_serviceguide_list command#2021Copilot wants to merge 3 commits intousers/skakara/waf-service-listfrom
Copilot wants to merge 3 commits intousers/skakara/waf-service-listfrom
Conversation
21 tasks
Co-authored-by: sriramkakara <47894548+sriramkakara@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on wellarchitectedframework_serviceguide_list command PR
Use reverse lookup dictionary for O(1) service guide URL lookups
Mar 12, 2026
sriramkakara
requested review from
conniey,
fanyang-mono,
jairmyree,
jongio,
joshfree,
weshaggard and
xiangyan99
and removed request for
a team
Member
|
@copilot Abandon this PR because the approach complicates the logic and the perf impact is negligible |
…ation Co-authored-by: sriramkakara <47894548+sriramkakara@users.noreply.github.com>
Contributor
Author
Copilot
AI
changed the title
Use reverse lookup dictionary for O(1) service guide URL lookups
Revert: address feedback on wellarchitectedframework_serviceguide_list command
Mar 12, 2026
Member
|
@copilot Close this PR without merging the changes i.e, discarding the changes |
Contributor
Author
I'm unable to close PRs directly — please close this PR manually from the GitHub UI using the "Close pull request" button at the bottom of the PR page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the reverse lookup dictionary changes introduced in response to the original review comment. The original
GetServiceGuideUrl()implementation — a linear scan overs_serviceGuidesCacheusingContainson each service's variations — has been restored, as the performance impact is negligible and the optimization added unnecessary complexity.Invoking Livetests
Copilot submitted PRs are not trustworthy by default. Users with
writeaccess to the repo need to validate the contents of this PR before leaving a comment with the text/azp run mcp - pullrequest - live. This will trigger the necessary livetest workflows to complete required validation.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.