Use ConnectionStringBuilder instead of string interpolation#2056
Merged
xiangyan99 merged 4 commits intomainfrom Mar 16, 2026
Merged
Use ConnectionStringBuilder instead of string interpolation#2056xiangyan99 merged 4 commits intomainfrom
xiangyan99 merged 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the PostgreSQL and MySQL tools against connection-string injection by switching from string interpolation to provider connection-string builders, and adds regression tests plus a server changelog entry documenting the fix.
Changes:
- PostgreSQL: replace interpolated connection strings with
NpgsqlConnectionStringBuildervia a new helper. - MySQL: replace interpolated connection strings with
MySqlConnectionStringBuildervia a new helper (and expose it for unit testing). - Add regression unit tests for connection-string injection scenarios and a changelog entry.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.Postgres/tests/Azure.Mcp.Tools.Postgres.UnitTests/Services/PostgresServiceConnectionStringInjectionTests.cs | New regression tests validating injected database values don’t override Host / SSL settings. |
| tools/Azure.Mcp.Tools.Postgres/src/Services/PostgresService.cs | Uses a new BuildConnectionString helper to build safe PostgreSQL connection strings. |
| tools/Azure.Mcp.Tools.MySql/tests/Azure.Mcp.Tools.MySql.UnitTests/Services/MySqlServiceConnectionStringInjectionTests.cs | New regression tests validating injected database/user values don’t override Server / SSL settings. |
| tools/Azure.Mcp.Tools.MySql/src/Services/MySqlService.cs | Uses MySqlConnectionStringBuilder via a new internal BuildConnectionString helper (SSL required). |
| servers/Azure.Mcp.Server/changelog-entries/1773675545058.yaml | Records the security bug fix in the server changelog. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
kk-src
approved these changes
Mar 16, 2026
ramnov
approved these changes
Mar 16, 2026
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Apr 20, 2026
…t#2056) * Use ConnectionStringBuilder instead of string interpolation * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * fix test * dotnet format --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[Provide a clear, concise description of the changes]Use ConnectionStringBuilder instead of string interpolation
[Any additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabel/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline