Sanitize table names for kusto query#2070
Merged
xiangyan99 merged 3 commits intomainfrom Mar 16, 2026
Merged
Conversation
xiangyan99
requested review from
a team,
danield137 and
prvavill
as code owners
xiangyan99
requested review from
KarishmaGhiya,
conniey,
hallipr,
jongio,
sandeep-sen,
tmeschter and
wbreza
Contributor
There was a problem hiding this comment.
Pull request overview
This PR mitigates KQL injection risks in the Kusto tool by escaping user-controlled table identifiers before interpolating them into KQL/management commands.
Changes:
- Added
KustoService.EscapeKqlIdentifierto escape table identifiers using KQL bracket notation and reject certain control characters. - Updated the sample query construction and corresponding unit tests to use escaped identifiers.
- Added unit tests covering escaping behavior and control-character rejection; added a changelog entry documenting the security fix.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.Kusto/tests/Azure.Mcp.Tools.Kusto.UnitTests/SampleCommandTests.cs | Updates expected query strings to match escaped/bracketed table identifiers. |
| tools/Azure.Mcp.Tools.Kusto/tests/Azure.Mcp.Tools.Kusto.UnitTests/EscapeKqlIdentifierTests.cs | Adds new unit tests for identifier escaping and injection prevention. |
| tools/Azure.Mcp.Tools.Kusto/src/Services/KustoService.cs | Introduces identifier escaping helper and applies it to .show table ... schema query. |
| tools/Azure.Mcp.Tools.Kusto/src/Commands/SampleCommand.cs | Escapes the user-provided table name when building the sample query. |
| servers/Azure.Mcp.Server/changelog-entries/1773696709347.yaml | Documents the bug/security fix in the Azure MCP Server changelog entries. |
danield137
approved these changes
Mar 16, 2026
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Apr 20, 2026
* Sanitize table names for kusto query * dotnet format * address feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[Provide a clear, concise description of the changes]Sanitize table names for kusto query
[Any additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabel/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline