Merged
Conversation
2. Disable more dangerous identifiers
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens the Postgres SQL query validation used by the Postgres tool to reduce exfiltration/privilege-abuse risk from user-provided SQL, and adds unit tests plus a changelog entry.
Changes:
- Block SQL set-operation keywords (UNION / INTERSECT / EXCEPT) in
SqlQueryValidator. - Expand the blocked identifier list (e.g.,
pg_user,pg_roles,generate_series,pg_stat_ssl) and adjust string/comment handling. - Add unit tests for validator behavior and a changelog entry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.Postgres/src/Validation/SqlQueryValidator.cs | Adds set-operation keyword blocking and updates string/comment scanning in the validator. |
| tools/Azure.Mcp.Tools.Postgres/tests/Azure.Mcp.Tools.Postgres.UnitTests/Validation/SqlQueryValidatorTests.cs | Introduces new unit tests for allowed/disallowed queries. |
| servers/Azure.Mcp.Server/changelog-entries/1773853286236.yaml | Records the validator hardening in the server changelog entry feed. |
scottaddie
reviewed
Mar 18, 2026
…r.cs Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
…r.cs Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
scottaddie
approved these changes
Mar 18, 2026
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Apr 20, 2026
* 1. Disallow keywords: UNION/INTERSECT/EXCEPT 2. Disable more dangerous identifiers * update * Update tools/Azure.Mcp.Tools.Postgres/src/Validation/SqlQueryValidator.cs Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com> * Update tools/Azure.Mcp.Tools.Postgres/src/Validation/SqlQueryValidator.cs Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com> --------- Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[Provide a clear, concise description of the changes][Any additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabel/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline