PG security enhancement#2097
Merged
Merged
Conversation
xiangyan99
requested review from
alzimmermsft,
jongio,
joshfree,
msalaman,
saikoumudi,
sandeep-sen and
weshaggard
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR strengthens the Postgres SQL query validation layer to further reduce injection/data-exfiltration risk for tool-executed queries, and documents the change in the Azure MCP Server changelog.
Changes:
- Block SQL set-operation keywords (UNION/INTERSECT/EXCEPT) during query validation.
- Expand the Postgres dangerous identifier blocklist and reduce false-positive comment detection by stripping string literals before scanning for comment markers.
- Add unit tests for the Postgres SQL query validator and update the Azure MCP Server changelog.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.Postgres/src/Validation/SqlQueryValidator.cs | Adds set-operation keyword blocking, expands dangerous identifiers, and improves comment detection by ignoring comment markers inside string literals. |
| tools/Azure.Mcp.Tools.Postgres/tests/Azure.Mcp.Tools.Postgres.UnitTests/Validation/SqlQueryValidatorTests.cs | Introduces unit tests covering safe queries and newly-blocked patterns (comments, set ops, dangerous identifiers, etc.). |
| servers/Azure.Mcp.Server/CHANGELOG.md | Notes the validator hardening under the Unreleased “Bugs Fixed” section. |
vcolin7
approved these changes
Mar 18, 2026
github-project-automation
Bot
moved this from Untriaged
to In Progress
in Azure MCP Server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[Provide a clear, concise description of the changes]Disallow keywords: UNION/INTERSECT/EXCEPT
Disable more dangerous identifiers
[Any additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabel/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline