MySQL security enhancement#2108
Merged
Merged
Conversation
21 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Enhances the MySQL query safety validator to reduce SQL-injection bypass vectors (notably comment-based obfuscation and set-operator exfiltration patterns) in the Azure MCP MySQL tool.
Changes:
- Block SQL comments (
--,#,/* ... */, and MySQL version comments/*!...*/) rather than stripping them. - Add set-operator keywords (
UNION/INTERSECT/EXCEPT) to the MySQL dangerous keyword blocklist and switch keyword/function detection to regex-based word-boundary matching. - Expand unit tests to cover string-literal edge cases and add explicit tests for comment and set-operation rejection; update Azure MCP Server changelog entry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.MySql/src/Services/MySqlService.cs | Updates query validation logic to reject comments and detect blocked keywords/functions via regex patterns. |
| tools/Azure.Mcp.Tools.MySql/tests/Azure.Mcp.Tools.MySql.UnitTests/Services/MySqlServiceQueryValidationTests.cs | Adds/adjusts tests for comment rejection, set operations, and reduced false positives in string literals. |
| servers/Azure.Mcp.Server/CHANGELOG.md | Documents the MySQL query validation security fix in the Unreleased changelog. |
vcolin7
reviewed
Mar 18, 2026
Co-authored-by: vcolin7 <victor.y.asi@gmail.com>
vcolin7
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[Provide a clear, concise description of the changes][Any additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabel/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline