Skip to content

Update telemetry to support more fields#2114

Merged
kvenkatrajan merged 3 commits intomicrosoft:mainfrom
saikoumudi:fix-plugin-telemetry-command
Mar 19, 2026
Merged

Update telemetry to support more fields#2114
kvenkatrajan merged 3 commits intomicrosoft:mainfrom
saikoumudi:fix-plugin-telemetry-command

Conversation

@saikoumudi
Copy link
Copy Markdown
Contributor

@saikoumudi saikoumudi commented Mar 19, 2026

What does this PR do?

  • Added plugin-version, skill-name, skill-version attributes to the command
  • renamed telemetry activity from plugins to plugin

[Any additional context, screenshots, or information that helps reviewers]
local execution screenshot
image

Aspire dashboard screenshot
image

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes using script at eng/scripts/Process-PackageReadMe.ps1. See Package README
    • Updated command list in /servers/Azure.Mcp.Server/docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • Run .\eng\scripts\Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the hidden plugin-telemetry command’s CLI surface to refer to “skills” instead of “plugins”, aligning telemetry inputs with the Skill telemetry onboarding work.

Changes:

  • Adjusted telemetry option help text to reference skill_invocation events.
  • Replaced the --plugin-name option with a SkillName option and wired it into PluginTelemetryCommand.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
core/Microsoft.Mcp.Core/src/Areas/Server/Options/PluginTelemetryOptionDefinitions.cs Renames/introduces the skill name option and updates event-type description examples.
core/Microsoft.Mcp.Core/src/Areas/Server/Commands/ToolLoading/PluginTelemetryCommand.cs Registers/binds the new skill name option in the telemetry publishing command.
Comments suppressed due to low confidence (1)

core/Microsoft.Mcp.Core/src/Areas/Server/Options/PluginTelemetryOptionDefinitions.cs:54

  • Switching from --plugin-name to --skill-name is a potentially breaking CLI change for existing agent hooks. Consider supporting --plugin-name as an additional alias for the new skill name option (or otherwise providing a transition path) to avoid silently dropping telemetry fields.
    public static readonly Option<string> SkillName = new(
        $"--{SkillName}"
    )
    {
        Description = "Name of the skill being invoked.",
        Required = false
    };

You can also share your feedback on Copilot code review. Take the survey.

@saikoumudi saikoumudi changed the title Update telemetry to use SkillName instead of PluginName Update telemetry to support more fields Mar 19, 2026
@github-project-automation github-project-automation Bot moved this from Untriaged to In Progress in Azure MCP Server Mar 19, 2026
@kvenkatrajan kvenkatrajan merged commit 53fe4f0 into microsoft:main Mar 19, 2026
15 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Azure MCP Server Mar 19, 2026
colbytimm pushed a commit to colbytimm/microsoft-mcp that referenced this pull request Apr 20, 2026
* Update telemetry to use SkillName instead of PluginName

* added plugin-version and skill-version

* Make plugin prefix singular
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants