Skip to content

Fix Monitor and Fabric Core tool names#2134

Merged
alzimmermsft merged 5 commits intomicrosoft:mainfrom
alzimmermsft:FixMonitorInvalidToolNames
Mar 20, 2026
Merged

Fix Monitor and Fabric Core tool names#2134
alzimmermsft merged 5 commits intomicrosoft:mainfrom
alzimmermsft:FixMonitorInvalidToolNames

Conversation

@alzimmermsft
Copy link
Copy Markdown
Contributor

@alzimmermsft alzimmermsft commented Mar 20, 2026

What does this PR do?

Fixes invalid tools names in Monitor and Fabric Core

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Monitor and Fabric tool identifiers to use dash-separated names (instead of underscores) and aligns docs/tests/changelog entries accordingly.

Changes:

  • Renamed multiple Fabric Docs/Core command names to dash-separated variants and updated related unit tests.
  • Renamed Azure Monitor instrumentation tool names to dash-separated variants and updated docs, prompts, and consolidated tool mappings.
  • Added changelog entries describing the breaking rename.

Reviewed changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tools/Fabric.Mcp.Tools.OneLake/src/Prompts/OneLakePrompts.cs Renames OneLake prompt identifier to dash-separated form.
tools/Fabric.Mcp.Tools.Docs/tests/Fabric.Mcp.Tools.Docs.UnitTests/FabricDocsSetupTests.cs Updates docs setup test expectations for renamed command keys.
tools/Fabric.Mcp.Tools.Docs/tests/Fabric.Mcp.Tools.Docs.UnitTests/Commands/PublicApisCommandsTests.cs Updates unit tests to expect renamed public API command names.
tools/Fabric.Mcp.Tools.Docs/tests/Fabric.Mcp.Tools.Docs.UnitTests/Commands/BestPracticesCommandsTests.cs Updates unit tests to expect renamed best-practices-related command names.
tools/Fabric.Mcp.Tools.Docs/src/Commands/PublicApis/GetWorkloadApisCommand.cs Renames workload API spec command to dash-separated name.
tools/Fabric.Mcp.Tools.Docs/src/Commands/PublicApis/GetPlatformApisCommand.cs Renames platform API spec command to dash-separated name.
tools/Fabric.Mcp.Tools.Docs/src/Commands/BestPractices/GetWorkloadDefinitionCommand.cs Renames item definitions command to dash-separated name.
tools/Fabric.Mcp.Tools.Docs/src/Commands/BestPractices/GetExamplesCommand.cs Renames API examples command to dash-separated name.
tools/Fabric.Mcp.Tools.Docs/src/Commands/BestPractices/GetBestPracticesCommand.cs Renames best practices command to dash-separated name.
tools/Fabric.Mcp.Tools.Core/tests/README.md Updates test README to reflect renamed core command.
tools/Fabric.Mcp.Tools.Core/tests/FabricCoreSetupTests.cs Updates setup test messaging for renamed core command (but assertion key still uses old name).
tools/Fabric.Mcp.Tools.Core/tests/Commands/ItemCreateCommandTests.cs Updates unit tests to expect renamed create-item command.
tools/Fabric.Mcp.Tools.Core/src/Commands/ItemCreateCommand.cs Renames core create item command to dash-separated name.
tools/Azure.Mcp.Tools.Monitor/tests/Azure.Mcp.Tools.Monitor.UnitTests/Instrumentation/Tools/GetLearningResourceToolTests.cs Updates validation message expected by tests for renamed tool name.
tools/Azure.Mcp.Tools.Monitor/src/Tools/Instrumentation/SendBrownfieldAnalysisTool.cs Updates user-facing instructions/messages to reference renamed tools; adds file header.
tools/Azure.Mcp.Tools.Monitor/src/Tools/Instrumentation/OrchestratorTool.cs Updates embedded workflow instructions to reference renamed tools; adds file header.
tools/Azure.Mcp.Tools.Monitor/src/Tools/Instrumentation/GetLearningResourceTool.cs Updates error messages to reference renamed tool name; adds file header.
tools/Azure.Mcp.Tools.Monitor/src/Options/Instrumentation/MonitorInstrumentationOptionDefinitions.cs Updates option help text to reference renamed tool name.
tools/Azure.Mcp.Tools.Monitor/src/Models/Instrumentation/Constants.cs Updates agent instruction string to reference renamed tool name; adds file header.
tools/Azure.Mcp.Tools.Monitor/src/Commands/Instrumentation/SendBrownfieldAnalysisCommand.cs Renames command and updates description references to renamed orchestrator tools.
tools/Azure.Mcp.Tools.Monitor/src/Commands/Instrumentation/OrchestratorStartCommand.cs Renames command and updates description references to renamed next tool.
tools/Azure.Mcp.Tools.Monitor/src/Commands/Instrumentation/OrchestratorNextCommand.cs Renames command and updates description references to renamed tools.
tools/Azure.Mcp.Tools.Monitor/src/Commands/Instrumentation/GetLearningResourceCommand.cs Renames command and updates description reference to renamed start tool.
servers/Fabric.Mcp.Server/changelog-entries/1774030612193.yaml Adds Fabric server breaking change entry for renamed tools.
servers/Fabric.Mcp.Server/README.md Updates documented Fabric tool names to dash-separated variants.
servers/Azure.Mcp.Server/src/Resources/consolidated-tools.json Updates mapped monitor instrumentation tool names to dash-separated variants.
servers/Azure.Mcp.Server/docs/e2eTestPrompts.md Updates e2e test prompt tool names for renamed monitor instrumentation tools.
servers/Azure.Mcp.Server/docs/azmcp-commands.md Updates CLI examples and notes to reference renamed monitor instrumentation commands.
servers/Azure.Mcp.Server/changelog-entries/1774030525892.yaml Adds Azure server breaking change entry for renamed tools (contains a typo).

Comment thread tools/Fabric.Mcp.Tools.Core/tests/FabricCoreSetupTests.cs Outdated
Comment thread servers/Azure.Mcp.Server/changelog-entries/1774030525892.yaml Outdated
@alzimmermsft alzimmermsft merged commit efae7b1 into microsoft:main Mar 20, 2026
15 checks passed
@github-project-automation github-project-automation Bot moved this from Untriaged to Done in Azure MCP Server Mar 20, 2026
@alzimmermsft alzimmermsft deleted the FixMonitorInvalidToolNames branch March 20, 2026 21:03
anannya03 pushed a commit to anannya03/mcp that referenced this pull request Mar 25, 2026
* Fix Monitor and Fabric Core tool names

* Add CHANGELOG entries

* CI follow-ups
colbytimm pushed a commit to colbytimm/microsoft-mcp that referenced this pull request Apr 20, 2026
* Fix Monitor and Fabric Core tool names

* Add CHANGELOG entries

* CI follow-ups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants