Add skill name allowlist for telemetry and expand file refs#2149
Merged
saikoumudi merged 1 commit intomicrosoft:mainfrom Mar 23, 2026
Merged
Add skill name allowlist for telemetry and expand file refs#2149saikoumudi merged 1 commit intomicrosoft:mainfrom
saikoumudi merged 1 commit intomicrosoft:mainfrom
Conversation
kvenkatrajan
approved these changes
Mar 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a skill-name allowlist to the plugin-telemetry command so telemetry won’t record customer-defined/custom skill names, and expands the allowed plugin file reference list to include newer skill reference files.
Changes:
- Added
allowed-skill-names.jsonand DI wiring for an embedded-resource-backed skill-name allowlist provider. - Updated
PluginTelemetryCommandto block telemetry requests with disallowed--skill-name. - Expanded
allowed-plugin-file-references.jsonwith additional Azure Enterprise Infra Planner reference files.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| servers/Azure.Mcp.Server/src/Resources/allowed-skill-names.json | New embedded resource defining the skill-name allowlist. |
| servers/Azure.Mcp.Server/src/Resources/allowed-plugin-file-references.json | Adds newly allowed reference file paths. |
| servers/Azure.Mcp.Server/src/Program.cs | Registers the new IPluginSkillNameAllowlistProvider in DI. |
| core/Microsoft.Mcp.Core/src/Areas/Server/Commands/ToolLoading/PluginTelemetryCommand.cs | Validates --skill-name against the allowlist and blocks disallowed values. |
| core/Microsoft.Mcp.Core/src/Areas/Server/Commands/ToolLoading/IPluginSkillNameAllowlistProvider.cs | Introduces the allowlist provider interface + embedded-resource implementation. |
| core/Microsoft.Mcp.Core/src/Areas/Server/Commands/ToolLoading/IPluginFileReferenceAllowlistProvider.cs | Removes an unnecessary using directive. |
kvenkatrajan
approved these changes
Mar 23, 2026
saikoumudi
added a commit
to saikoumudi/mcp
that referenced
this pull request
Mar 23, 2026
This was referenced Mar 23, 2026
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added skill name allowlist to ensure we don't accidentally log custom skills customer might have created. Updated the file references to contain the latest skill references
[Add additional context, screenshots, or information that helps reviewers]GitHub issue number?
#1923
Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline