Skip to content

Restrict critical parameters for PG tool (#2156)#2164

Merged
xiangyan99 merged 1 commit intorelease/azure/2.xfrom
pg_restrict_critical_parameters_2.x
Mar 23, 2026
Merged

Restrict critical parameters for PG tool (#2156)#2164
xiangyan99 merged 1 commit intorelease/azure/2.xfrom
pg_restrict_critical_parameters_2.x

Conversation

@xiangyan99
Copy link
Copy Markdown
Member

  • Added parameter allowlist validation for the PostgreSQL server param set command to restrict modifications to safe, non-security-critical parameters only

  • update

What does this PR do?

[Provide a clear, concise description of the changes]

Cherry pick 4b2ea77

[Add additional context, screenshots, or information that helps reviewers]

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

* Added parameter allowlist validation for the PostgreSQL server param set command to restrict modifications to safe, non-security-critical parameters only

* update
Copilot AI review requested due to automatic review settings March 23, 2026 20:37
@xiangyan99 xiangyan99 requested review from a team and kk-src as code owners March 23, 2026 20:37
@xiangyan99 xiangyan99 requested review from JasonYeMSFT, JonathanCrd, chidozieononiwu, fanyang-mono, g2vinay, joshfree and vukelich and removed request for a team March 23, 2026 20:37
@github-actions github-actions Bot added the tools-Postgres PostgreSQL label Mar 23, 2026
@github-project-automation github-project-automation Bot moved this from Untriaged to In Progress in Azure MCP Server Mar 23, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hardens the Azure MCP PostgreSQL tool’s server param set command by preventing updates to security-sensitive PostgreSQL server parameters, reducing the risk of prompt-injection/agent misuse.

Changes:

  • Added a ServerParameterValidator that blocks updates to a set of security-sensitive PostgreSQL parameters by throwing CommandValidationException (403).
  • Wired the validator into ServerParamSetCommand.ExecuteAsync to enforce the restriction before calling the service layer.
  • Updated/added unit tests covering blocked parameters and validator behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
tools/Azure.Mcp.Tools.Postgres/tests/Azure.Mcp.Tools.Postgres.UnitTests/Server/ServerParamSetCommandTests.cs Updates existing tests and adds new coverage for blocked parameters and validator edge cases.
tools/Azure.Mcp.Tools.Postgres/src/Validation/ServerParameterValidator.cs Introduces a security-sensitive parameter blocklist validator that throws structured validation exceptions.
tools/Azure.Mcp.Tools.Postgres/src/Commands/Server/ServerParamSetCommand.cs Enforces parameter validation prior to executing the parameter update service call.
servers/Azure.Mcp.Server/changelog-entries/1774291948051.yaml Adds a changelog entry describing the new parameter restriction behavior.

Comment thread servers/Azure.Mcp.Server/changelog-entries/1774291948051.yaml
@xiangyan99 xiangyan99 merged commit f667294 into release/azure/2.x Mar 23, 2026
30 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Azure MCP Server Mar 23, 2026
@xiangyan99 xiangyan99 deleted the pg_restrict_critical_parameters_2.x branch March 23, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools-Postgres PostgreSQL

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants