Restrict critical parameters for PG tool (#2156)#2164
Merged
xiangyan99 merged 1 commit intorelease/azure/2.xfrom Mar 23, 2026
Merged
Restrict critical parameters for PG tool (#2156)#2164xiangyan99 merged 1 commit intorelease/azure/2.xfrom
xiangyan99 merged 1 commit intorelease/azure/2.xfrom
Conversation
* Added parameter allowlist validation for the PostgreSQL server param set command to restrict modifications to safe, non-security-critical parameters only * update
vcolin7
approved these changes
Mar 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the Azure MCP PostgreSQL tool’s server param set command by preventing updates to security-sensitive PostgreSQL server parameters, reducing the risk of prompt-injection/agent misuse.
Changes:
- Added a
ServerParameterValidatorthat blocks updates to a set of security-sensitive PostgreSQL parameters by throwingCommandValidationException(403). - Wired the validator into
ServerParamSetCommand.ExecuteAsyncto enforce the restriction before calling the service layer. - Updated/added unit tests covering blocked parameters and validator behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.Postgres/tests/Azure.Mcp.Tools.Postgres.UnitTests/Server/ServerParamSetCommandTests.cs | Updates existing tests and adds new coverage for blocked parameters and validator edge cases. |
| tools/Azure.Mcp.Tools.Postgres/src/Validation/ServerParameterValidator.cs | Introduces a security-sensitive parameter blocklist validator that throws structured validation exceptions. |
| tools/Azure.Mcp.Tools.Postgres/src/Commands/Server/ServerParamSetCommand.cs | Enforces parameter validation prior to executing the parameter update service call. |
| servers/Azure.Mcp.Server/changelog-entries/1774291948051.yaml | Adds a changelog entry describing the new parameter restriction behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added parameter allowlist validation for the PostgreSQL server param set command to restrict modifications to safe, non-security-critical parameters only
update
What does this PR do?
[Provide a clear, concise description of the changes]Cherry pick 4b2ea77
[Add additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline