disable publicNetworkAccess by default(#2170)#2179
Merged
xiangyan99 merged 1 commit intorelease/azure/2.xfrom Mar 24, 2026
Merged
disable publicNetworkAccess by default(#2170)#2179xiangyan99 merged 1 commit intorelease/azure/2.xfrom
xiangyan99 merged 1 commit intorelease/azure/2.xfrom
Conversation
* disable publicNetworkAccess by defailt * update
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Azure Managed Redis create flow to disable public network access by default and introduces a new CLI option so users can explicitly enable it when creating a resource.
Changes:
- Added
--public-network-accessoption to the Rediscreatecommand and plumbed it through command binding intoIRedisService.CreateResourceAsync(...). - Updated the ARM/Bicep template parameters so
publicNetworkAccessis parameterized and defaults toDisabled. - Expanded/added unit tests to validate the new option and the updated service call signature.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.Redis/src/Services/RedisService.cs | Adds publicNetworkAccessEnabled handling and wires it into the deployment template parameters (default Disabled). |
| tools/Azure.Mcp.Tools.Redis/src/Services/IRedisService.cs | Extends the create contract to accept publicNetworkAccessEnabled. |
| tools/Azure.Mcp.Tools.Redis/src/Commands/ResourceCreateCommand.cs | Registers/binds the new CLI option and passes it to the service layer. |
| tools/Azure.Mcp.Tools.Redis/src/Options/RedisOptionDefinitions.cs | Introduces the --public-network-access option definition. |
| tools/Azure.Mcp.Tools.Redis/src/Options/ResourceCreateOptions.cs | Adds PublicNetworkAccessEnabled to the command options model. |
| tools/Azure.Mcp.Tools.Redis/src/Models/ManagedRedis/RedisCreateParameters.cs | Adds the publicNetworkAccess parameter to the deployment parameter model. |
| tools/Azure.Mcp.Tools.Redis/tests/Azure.Mcp.Tools.Redis.UnitTests/ResourceCreateCommandTests.cs | Updates tests for the new parameter and adds coverage for enabling public network access. |
| servers/Azure.Mcp.Server/changelog-entries/1774302063329.yaml | Adds a changelog entry describing the new option and default behavior. |
joshfree
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
disable publicNetworkAccess by defailt
update
What does this PR do?
[Provide a clear, concise description of the changes][Add additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline