Azsql default disable pub network 2.x#2181
Merged
xiangyan99 merged 3 commits intorelease/azure/2.xfrom Mar 24, 2026
Merged
Conversation
* disable publicNetworkAccess by defailt * update
* make `public-network-access` disabled by default * updates
…into release/azure/2.x
xiangyan99
requested review from
a team,
achyuth-ms,
ericshape and
jeremyfrosti
as code owners
xiangyan99
requested review from
KarishmaGhiya,
Copilot,
g2vinay,
hallipr,
jongio,
tmeschter and
wbreza
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Azure SQL tool’s server creation behavior to be secure-by-default by disabling public network access unless explicitly enabled, and refreshes related docs/tests/changelog.
Changes:
- Default SQL server
PublicNetworkAccesstoDisabledinSqlService.CreateServerAsyncwhen the flag is omitted. - Update SQL option help text and the generated
azmcpcommand documentation to reflect the new default. - Add unit tests and a changelog entry covering the behavior change.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.Sql/tests/Azure.Mcp.Tools.Sql.UnitTests/Server/ServerCreateCommandTests.cs | Adds tests around omitted/invalid --public-network-access behavior. |
| tools/Azure.Mcp.Tools.Sql/src/Services/SqlService.cs | Changes server creation to always set PublicNetworkAccess, defaulting to Disabled. |
| tools/Azure.Mcp.Tools.Sql/src/Options/SqlOptionDefinitions.cs | Updates CLI option description to state the new default. |
| servers/Azure.Mcp.Server/docs/azmcp-commands.md | Updates SQL server create command docs to show correct parameter names and new default. |
| servers/Azure.Mcp.Server/changelog-entries/1774310506935.yaml | Adds a changelog entry for the default change. |
alzimmermsft
approved these changes
Mar 24, 2026
github-project-automation
Bot
moved this from Untriaged
to In Progress
in Azure MCP Server
anannya03
pushed a commit
to anannya03/mcp
that referenced
this pull request
Mar 24, 2026
* disable publicNetworkAccess by defailt (microsoft#2170) * disable publicNetworkAccess by defailt * update * make `public-network-access` disabled by default (microsoft#2174) * make `public-network-access` disabled by default * updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[Provide a clear, concise description of the changes][Add additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline