Added input validation for ledger names (#2204)#2211
Merged
xiangyan99 merged 1 commit intorelease/azure/2.xfrom Mar 26, 2026
Merged
Added input validation for ledger names (#2204)#2211xiangyan99 merged 1 commit intorelease/azure/2.xfrom
xiangyan99 merged 1 commit intorelease/azure/2.xfrom
Conversation
* Added input validation for ledger names * address feedback * update * update
xiangyan99
requested review from
a team,
ivarprudnikov and
taicchoumsft
as code owners
xiangyan99
requested review from
KarishmaGhiya,
Copilot,
hallipr,
jongio and
wbreza
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds stricter validation for Azure Confidential Ledger ledgerName inputs to prevent malformed names (and reduce SSRF-style endpoint construction risks) before constructing the data-plane URI.
Changes:
- Added unit tests covering a set of invalid
ledgerNamevalues for bothGetLedgerEntryAsyncandAppendEntryAsync. - Introduced a centralized
ValidateLedgerNamehelper and ensured URI creation uses the validated value. - Added a changelog entry documenting the fix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.ConfidentialLedger/tests/Azure.Mcp.Tools.ConfidentialLedger.UnitTests/LedgerEntryGetCommandTests.cs | Adds theory-based tests asserting invalid ledger names are rejected. |
| tools/Azure.Mcp.Tools.ConfidentialLedger/src/Services/ConfidentialLedgerService.cs | Validates ledger names before building the ledger endpoint URI and creating the client. |
| servers/Azure.Mcp.Server/changelog-entries/1774461512052.yaml | Records the bug fix in the Azure MCP Server changelog system. |
anannya03
approved these changes
Mar 26, 2026
github-project-automation
Bot
moved this from Untriaged
to In Progress
in Azure MCP Server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added input validation for ledger names
address feedback
update
update
What does this PR do?
[Provide a clear, concise description of the changes][Add additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline