Port PR: Update to secure AzureCloudConfiguration (#2218)#2257
Merged
jairmyree merged 1 commit intorelease/azure/2.xfrom Mar 27, 2026
Merged
Port PR: Update to secure AzureCloudConfiguration (#2218)#2257jairmyree merged 1 commit intorelease/azure/2.xfrom
jairmyree merged 1 commit intorelease/azure/2.xfrom
Conversation
* Update to AzureCloudConfiguration * [WIP] Update to secure AzureCloudConfiguration (#2219) * Initial plan * Fix: throw ArgumentException for unknown/URI-like cloud values; clarify docs Agent-Logs-Url: https://github.com/microsoft/mcp/sessions/70697e6f-a81f-472b-bade-07a395f7956f Co-authored-by: jairmyree <67484440+jairmyree@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jairmyree <67484440+jairmyree@users.noreply.github.com> * Updating tests to reflect that custom authority hosts are not allowed * Changelog entry * Updating tests to reflect custom authority host not being allowed --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
jairmyree
requested review from
JasonYeMSFT,
Copilot,
g2vinay,
joshfree,
msalaman,
saikoumudi and
sandeep-sen
and removed request for
a team
anannya03
approved these changes
Mar 27, 2026
github-project-automation
Bot
moved this from Untriaged
to In Progress
in Azure MCP Server
xiangyan99
approved these changes
Mar 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Ports the secure cloud-environment handling change from #2218 by standardizing Azure authority host selection and removing support for custom authority-host URLs.
Changes:
- Update
AzureCloudConfigurationto useAzureAuthorityHostsand throw on unrecognized--cloudvalues (no URL parsing / no silent fallback). - Remove/update unit test coverage that previously allowed custom
https://...cloud values. - Update sovereign cloud documentation and add a breaking-change changelog entry.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| servers/Azure.Mcp.Server/changelog-entries/1774543138326.yaml | Records the breaking change for --cloud behavior (no custom URLs; unknown throws). |
| docs/sovereign-clouds.md | Updates docs to state only well-known cloud names are supported. |
| core/Microsoft.Mcp.Core/tests/Microsoft.Mcp.Core.UnitTests/Services/Telemetry/TelemetryServiceTests.cs | Removes custom authority-host URL inputs from telemetry cloud-tag tests. |
| core/Microsoft.Mcp.Core/src/Services/Azure/Authentication/AzureCloudConfiguration.cs | Switches to AzureAuthorityHosts and throws ArgumentException on unknown cloud values. |
| core/Azure.Mcp.Core/tests/Azure.Mcp.Core.UnitTests/Services/Azure/Authentication/AzureCloudConfigurationTests.cs | Removes custom URL tests and updates unknown-cloud behavior to expect exceptions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports over the fix from this PR: #2218