Skip to content

Remove Storage container create examples with parameters that don't exist#2262

Merged
alzimmermsft merged 2 commits intomicrosoft:mainfrom
alzimmermsft:RemoveContainerCreateExamplesThatDontWork
Mar 27, 2026
Merged

Remove Storage container create examples with parameters that don't exist#2262
alzimmermsft merged 2 commits intomicrosoft:mainfrom
alzimmermsft:RemoveContainerCreateExamplesThatDontWork

Conversation

@alzimmermsft
Copy link
Copy Markdown
Contributor

@alzimmermsft alzimmermsft commented Mar 27, 2026

What does this PR do?

Removes examples and tool description text referencing parameters that don't exist.

GitHub issue number?

Fixes #2242

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

@alzimmermsft alzimmermsft self-assigned this Mar 27, 2026
@alzimmermsft alzimmermsft marked this pull request as ready for review March 27, 2026 20:53
@alzimmermsft alzimmermsft requested a review from jongio as a code owner March 27, 2026 20:53
Copilot AI review requested due to automatic review settings March 27, 2026 20:53
@alzimmermsft alzimmermsft requested review from a team and xiangyan99 as code owners March 27, 2026 20:53
@github-project-automation github-project-automation bot moved this from Untriaged to In Progress in Azure MCP Server Mar 27, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes documentation/examples referencing unsupported parameters for the Storage blob container create tool (fixes #2242).

Changes:

  • Updated the container create tool description to remove the non-existent --public-access-level parameter mention.
  • Removed e2e test prompts that asked for container public access settings that the tool doesn’t accept.
  • Added a changelog entry documenting the fix.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tools/Azure.Mcp.Tools.Storage/src/Commands/Blob/Container/ContainerCreateCommand.cs Removes the unsupported optional parameter from the tool’s user-facing description.
servers/Azure.Mcp.Server/docs/e2eTestPrompts.md Deletes prompts that reference unsupported “public access” container creation behavior.
servers/Azure.Mcp.Server/changelog-entries/1774644933443.yaml Records the documentation/example fix in the server changelog.

@alzimmermsft alzimmermsft merged commit 2833e38 into microsoft:main Mar 27, 2026
15 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure MCP Server Mar 27, 2026
alzimmermsft added a commit to alzimmermsft/mcp that referenced this pull request Mar 27, 2026
…xist (microsoft#2262)

* Remove Storage container create examples with parameters that don't exist

* Add CHANGELOG entry
alzimmermsft added a commit that referenced this pull request Mar 27, 2026
…xist (#2264)

Remove Storage container create examples with parameters that don't exist (#2262)

* Remove Storage container create examples with parameters that don't exist

* Add CHANGELOG entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[All & Namespace mode] storage_blob_container_create cannot set public access level due to public-access-level is not exposed

4 participants