Skip to content

Set SearchAudience based on Cloud configuration when creating Search SDK clients#2283

Merged
alzimmermsft merged 1 commit intomicrosoft:release/azure/2.xfrom
alzimmermsft:release/azure/2.x
Mar 30, 2026
Merged

Set SearchAudience based on Cloud configuration when creating Search SDK clients#2283
alzimmermsft merged 1 commit intomicrosoft:release/azure/2.xfrom
alzimmermsft:release/azure/2.x

Conversation

@alzimmermsft
Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes authentication issues with Azure AI Search tools where they weren't setting SearchAudience based on the cloud configuration of Azure MCP, resulting in a mismatch audience issue.

Now all Search SDKs have SearchAudience configured based on which cloud is being interacted with.

GitHub issue number?

Backports fix for #2276

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

…SDK clients (microsoft#2278)

* Set SearchAudience based on Cloud configuration when creating Search SDK clients

* Update cache key to include cloud
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes Azure AI Search authentication for sovereign clouds by configuring SearchClientOptions.Audience based on the active Azure cloud configuration, ensuring OAuth token scopes match the data-plane endpoint audience.

Changes:

  • Set SearchClientOptions.Audience when creating SearchIndexClient and KnowledgeBaseRetrievalClient.
  • Include cloud type in Search tool cache keys to avoid cross-cloud cache reuse.
  • Add an Azure MCP Server changelog entry for the bug fix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
tools/Azure.Mcp.Tools.Search/src/Services/SearchService.cs Sets Search SDK audience per cloud and updates cache keys to include cloud type.
servers/Azure.Mcp.Server/changelog-entries/1774884924148.yaml Adds a changelog entry describing the SearchAudience fix.

Comment thread servers/Azure.Mcp.Server/changelog-entries/1774884924148.yaml
Comment thread tools/Azure.Mcp.Tools.Search/src/Services/SearchService.cs
Comment thread tools/Azure.Mcp.Tools.Search/src/Services/SearchService.cs
Comment thread tools/Azure.Mcp.Tools.Search/src/Services/SearchService.cs
@alzimmermsft alzimmermsft merged commit 1c2b028 into microsoft:release/azure/2.x Mar 30, 2026
30 checks passed
@github-project-automation github-project-automation Bot moved this from Untriaged to Done in Azure MCP Server Mar 30, 2026
@alzimmermsft alzimmermsft deleted the release/azure/2.x branch March 30, 2026 19:53
Copilot AI mentioned this pull request Mar 31, 2026
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants