Skip to content

Set AppConfigurationAudience based on Cloud configuration when creating App Configuration SDK clients#2287

Merged
alzimmermsft merged 1 commit intomicrosoft:release/azure/2.xfrom
alzimmermsft:AddMissingAppConfigurationAudience2.x
Mar 30, 2026
Merged

Set AppConfigurationAudience based on Cloud configuration when creating App Configuration SDK clients#2287
alzimmermsft merged 1 commit intomicrosoft:release/azure/2.xfrom
alzimmermsft:AddMissingAppConfigurationAudience2.x

Conversation

@alzimmermsft
Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes authentication issues with App Configuration tools where they weren't setting AppConfigurationAudience based on the cloud configuration of Azure MCP, resulting in a mismatch audience issue.

Now all App Configuration SDKs have AppConfigurationAudience configured based on which cloud is being interacted with.

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

…ng App Configuration SDK clients (microsoft#2279)

* Set AppConfigurationAudience based on Cloud configuration when creating App Configuration SDK clients

* Pass tenant to credential retrieval

* Fix method typo
@alzimmermsft alzimmermsft self-assigned this Mar 30, 2026
@alzimmermsft alzimmermsft requested a review from conniey as a code owner March 30, 2026 18:47
Copilot AI review requested due to automatic review settings March 30, 2026 18:47
@alzimmermsft alzimmermsft requested review from a team and JonathanCrd as code owners March 30, 2026 18:47
@alzimmermsft alzimmermsft requested review from jongio, saikoumudi, sandeep-sen, wbreza and xiangyan99 and removed request for a team March 30, 2026 18:47
@github-project-automation github-project-automation Bot moved this from Untriaged to In Progress in Azure MCP Server Mar 30, 2026
@github-actions github-actions Bot added the tools-AppConfig AppConfig label Mar 30, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes App Configuration authentication in sovereign clouds by configuring the Azure App Configuration SDK client’s AppConfigurationAudience based on Azure MCP’s cloud configuration.

Changes:

  • Pass tenant context through App Configuration store lookup and credential creation.
  • Configure ConfigurationClientOptions.Audience based on the configured cloud (Public/China/US Gov).
  • Add a changelog entry documenting the bug fix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
tools/Azure.Mcp.Tools.AppConfig/src/Services/AppConfigService.cs Sets ConfigurationClientOptions.Audience from cloud config and threads tenant through client creation/query.
servers/Azure.Mcp.Server/changelog-entries/1774886640626.yaml Records the bug fix in the server changelog entry format.

Comment thread tools/Azure.Mcp.Tools.AppConfig/src/Services/AppConfigService.cs
Comment thread tools/Azure.Mcp.Tools.AppConfig/src/Services/AppConfigService.cs
@alzimmermsft alzimmermsft merged commit 6869fad into microsoft:release/azure/2.x Mar 30, 2026
29 checks passed
@alzimmermsft alzimmermsft deleted the AddMissingAppConfigurationAudience2.x branch March 30, 2026 19:40
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Azure MCP Server Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants