Skip to content

Fix namespace: Microsoft.Mcp.Core.Areas.Server.Commands -> Microsoft.Mcp.Core.Areas.Server.Commands.ServerInstructions#2301

Merged
alzimmermsft merged 1 commit into
microsoft:mainfrom
alzimmermsft:FinishMicrosoftNamespaceMigrationPart2
Mar 31, 2026
Merged

Fix namespace: Microsoft.Mcp.Core.Areas.Server.Commands -> Microsoft.Mcp.Core.Areas.Server.Commands.ServerInstructions#2301
alzimmermsft merged 1 commit into
microsoft:mainfrom
alzimmermsft:FinishMicrosoftNamespaceMigrationPart2

Conversation

@alzimmermsft
Copy link
Copy Markdown
Contributor

What does this PR do?

Part of fixing namespaces in Microsoft.Mcp.Core, Microsoft.Mcp.Core.Areas.Server.Commands -> Microsoft.Mcp.Core.Areas.Server.Commands.ServerInstructions

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

…Mcp.Core.Areas.Server.Commands.ServerInstructions
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR completes a namespace refactor in Microsoft.Mcp.Core by moving server-instructions types out of Microsoft.Mcp.Core.Areas.Server.Commands into the more specific Microsoft.Mcp.Core.Areas.Server.Commands.ServerInstructions, and updates downstream servers/tests to reference the new namespace.

Changes:

  • Moved IServerInstructionsProvider, NullServerInstructionsProvider, and ResourceServerInstructionsProvider into ...Commands.ServerInstructions.
  • Updated DI setup/entrypoints (Azure/Fabric/Template servers) and unit tests to import the new namespace.
  • Cleaned up now-unused using directives in server Program.cs files.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
servers/Template.Mcp.Server/src/Program.cs Updates using directives to the new ServerInstructions namespace and removes an unused localization import.
servers/Fabric.Mcp.Server/src/Program.cs Updates using directives to the new ServerInstructions namespace and removes unused imports.
servers/Azure.Mcp.Server/src/Program.cs Imports the new ServerInstructions namespace for instruction provider registration.
servers/Azure.Mcp.Server/tests/Azure.Mcp.Server.UnitTests/Infrastructure/ServiceRegistrationTests.cs Updates the test import to the new ServerInstructions namespace.
core/Microsoft.Mcp.Core/src/Areas/Server/Commands/ServiceCollectionExtensions.cs Imports the new namespace so server-options configuration continues to reference IServerInstructionsProvider.
core/Microsoft.Mcp.Core/src/Areas/Server/Commands/ServerInstructions/IServerInstructionsProvider.cs Changes namespace to ...Commands.ServerInstructions.
core/Microsoft.Mcp.Core/src/Areas/Server/Commands/ServerInstructions/NullServerInstructionsProvider.cs Changes namespace to ...Commands.ServerInstructions.
core/Microsoft.Mcp.Core/src/Areas/Server/Commands/ServerInstructions/ResourceServerInstructionsProvider.cs Changes namespace to ...Commands.ServerInstructions.
core/Azure.Mcp.Core/tests/Azure.Mcp.Core.UnitTests/Areas/Server/Commands/ServiceCollectionExtensionsTests.cs Imports the new ServerInstructions namespace to keep tests compiling.

@alzimmermsft alzimmermsft merged commit cdd198e into microsoft:main Mar 31, 2026
29 checks passed
@alzimmermsft alzimmermsft deleted the FinishMicrosoftNamespaceMigrationPart2 branch March 31, 2026 17:04
@github-project-automation github-project-automation Bot moved this from Untriaged to Done in Azure MCP Server Mar 31, 2026
colbytimm pushed a commit to colbytimm/microsoft-mcp that referenced this pull request Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants