Fix namespace: Microsoft.Mcp.Core.Areas.Server.Commands -> Microsoft.Mcp.Core.Areas.Server.Commands.ServerInstructions#2301
Merged
alzimmermsft merged 1 commit intoMar 31, 2026
Conversation
…Mcp.Core.Areas.Server.Commands.ServerInstructions
Contributor
There was a problem hiding this comment.
Pull request overview
This PR completes a namespace refactor in Microsoft.Mcp.Core by moving server-instructions types out of Microsoft.Mcp.Core.Areas.Server.Commands into the more specific Microsoft.Mcp.Core.Areas.Server.Commands.ServerInstructions, and updates downstream servers/tests to reference the new namespace.
Changes:
- Moved
IServerInstructionsProvider,NullServerInstructionsProvider, andResourceServerInstructionsProviderinto...Commands.ServerInstructions. - Updated DI setup/entrypoints (Azure/Fabric/Template servers) and unit tests to import the new namespace.
- Cleaned up now-unused
usingdirectives in serverProgram.csfiles.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| servers/Template.Mcp.Server/src/Program.cs | Updates using directives to the new ServerInstructions namespace and removes an unused localization import. |
| servers/Fabric.Mcp.Server/src/Program.cs | Updates using directives to the new ServerInstructions namespace and removes unused imports. |
| servers/Azure.Mcp.Server/src/Program.cs | Imports the new ServerInstructions namespace for instruction provider registration. |
| servers/Azure.Mcp.Server/tests/Azure.Mcp.Server.UnitTests/Infrastructure/ServiceRegistrationTests.cs | Updates the test import to the new ServerInstructions namespace. |
| core/Microsoft.Mcp.Core/src/Areas/Server/Commands/ServiceCollectionExtensions.cs | Imports the new namespace so server-options configuration continues to reference IServerInstructionsProvider. |
| core/Microsoft.Mcp.Core/src/Areas/Server/Commands/ServerInstructions/IServerInstructionsProvider.cs | Changes namespace to ...Commands.ServerInstructions. |
| core/Microsoft.Mcp.Core/src/Areas/Server/Commands/ServerInstructions/NullServerInstructionsProvider.cs | Changes namespace to ...Commands.ServerInstructions. |
| core/Microsoft.Mcp.Core/src/Areas/Server/Commands/ServerInstructions/ResourceServerInstructionsProvider.cs | Changes namespace to ...Commands.ServerInstructions. |
| core/Azure.Mcp.Core/tests/Azure.Mcp.Core.UnitTests/Areas/Server/Commands/ServiceCollectionExtensionsTests.cs | Imports the new ServerInstructions namespace to keep tests compiling. |
conniey
approved these changes
Mar 31, 2026
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Apr 20, 2026
…Mcp.Core.Areas.Server.Commands.ServerInstructions (microsoft#2301)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of fixing namespaces in
Microsoft.Mcp.Core,Microsoft.Mcp.Core.Areas.Server.Commands->Microsoft.Mcp.Core.Areas.Server.Commands.ServerInstructionsGitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline