Added ClientName and ToolArea (#2314)#2324
Merged
vcolin7 merged 2 commits intomicrosoft:release/azure/2.xfrom Apr 1, 2026
Merged
Added ClientName and ToolArea (#2314)#2324vcolin7 merged 2 commits intomicrosoft:release/azure/2.xfrom
vcolin7 merged 2 commits intomicrosoft:release/azure/2.xfrom
Conversation
* Added ClientName and ClientType will be deprecated when we see less usage data. Added ToolArea which will be used later. Added unit tests * updated changelog * Update core/Microsoft.Mcp.Core/src/Areas/Server/Options/PluginTelemetryOptions.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * update required field * Update core/Azure.Mcp.Core/tests/Azure.Mcp.Core.UnitTests/Areas/Server/Commands/ToolLoading/PluginTelemetryCommandTests.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * revert back ClientName to be optional to avoid breaking change * remove toolarea in definition until it's used in telemetry logging. update the description * update description examples * update changelog --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the plugin-telemetry tool’s input surface to capture richer client identity (adding ClientName alongside legacy ClientType) and introduces a placeholder ToolArea field for future use, with corresponding telemetry tagging updates and unit test coverage.
Changes:
- Add
clientNamesupport end-to-end (options model, CLI option definition/binding, telemetry tag emission). - Add
toolAreaas a newPluginTelemetryOptionsmodel property (not yet emitted as telemetry). - Add a unit test to validate telemetry tags, and update the Azure MCP Server changelog.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| servers/Azure.Mcp.Server/CHANGELOG.md | Adds an unreleased changelog note for the new telemetry fields. |
| core/Microsoft.Mcp.Core/src/Areas/Server/Options/PluginTelemetryOptions.cs | Extends the options model with ClientName and ToolArea JSON properties. |
| core/Microsoft.Mcp.Core/src/Areas/Server/Options/PluginTelemetryOptionDefinitions.cs | Adds --client-name option and deprecates --client-type in description. |
| core/Microsoft.Mcp.Core/src/Areas/Server/Commands/ToolLoading/PluginTelemetryCommand.cs | Registers/binds --client-name and emits a Plugin_ClientName telemetry tag. |
| core/Azure.Mcp.Core/tests/Azure.Mcp.Core.UnitTests/Areas/Server/Commands/ToolLoading/PluginTelemetryCommandTests.cs | Adds a test verifying the activity tags set by LogPluginTelemetry. |
Contributor
|
Should I be expecting the whitelisting of toolnames here? |
kvenkatrajan
approved these changes
Apr 1, 2026
Contributor
Author
No Kay. allowlisting toolnames PR is already merged into release branch - #2291 |
vcolin7
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[Provide a clear, concise description of the changes]Added ClientName and ClientType will be deprecated when we see less usage data. Added ToolArea which will be used later. Added unit tests
[Add additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline