Added input validation for storage (#2348)#2350
Merged
xiangyan99 merged 1 commit intorelease/azure/2.xfrom Apr 6, 2026
Merged
Conversation
* Added input validation for storage * updates * update test * fix tests * update * update
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds storage account name input validation in StorageService to prevent invalid/malicious account values from being used when constructing Storage service endpoints, along with unit tests and a changelog entry.
Changes:
- Introduces
ValidateStorageAccountNameand calls it from blob/table endpoint construction. - Adds unit tests covering valid/invalid account name scenarios (including SSRF-style payloads).
- Adds a changelog entry for the fix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.Storage/src/Services/StorageService.cs | Adds account name validation and applies it during endpoint URI creation. |
| tools/Azure.Mcp.Tools.Storage/tests/Azure.Mcp.Tools.Storage.UnitTests/Services/StorageServiceValidateAccountNameTests.cs | New unit tests for the account-name validation behavior. |
| servers/Azure.Mcp.Server/changelog-entries/1775486642509.yaml | Documents the storage account name validation change as a bug fix. |
DavidParks8
reviewed
Apr 6, 2026
srnagar
reviewed
Apr 6, 2026
DavidParks8
approved these changes
Apr 6, 2026
srnagar
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added input validation for storage
updates
update test
fix tests
update
update
What does this PR do?
[Provide a clear, concise description of the changes][Add additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline