Skip to content

Added input validation for storage (#2348)#2350

Merged
xiangyan99 merged 1 commit intorelease/azure/2.xfrom
storage_validation_2.x
Apr 6, 2026
Merged

Added input validation for storage (#2348)#2350
xiangyan99 merged 1 commit intorelease/azure/2.xfrom
storage_validation_2.x

Conversation

@xiangyan99
Copy link
Copy Markdown
Member

  • Added input validation for storage

  • updates

  • update test

  • fix tests

  • update

  • update

What does this PR do?

[Provide a clear, concise description of the changes]

[Add additional context, screenshots, or information that helps reviewers]

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

* Added input validation for storage

* updates

* update test

* fix tests

* update

* update
Copilot AI review requested due to automatic review settings April 6, 2026 16:52
@xiangyan99 xiangyan99 requested review from a team as code owners April 6, 2026 16:52
@xiangyan99 xiangyan99 requested review from joshfree and removed request for a team April 6, 2026 16:52
@github-project-automation github-project-automation Bot moved this to Untriaged in Azure MCP Server Apr 6, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds storage account name input validation in StorageService to prevent invalid/malicious account values from being used when constructing Storage service endpoints, along with unit tests and a changelog entry.

Changes:

  • Introduces ValidateStorageAccountName and calls it from blob/table endpoint construction.
  • Adds unit tests covering valid/invalid account name scenarios (including SSRF-style payloads).
  • Adds a changelog entry for the fix.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
tools/Azure.Mcp.Tools.Storage/src/Services/StorageService.cs Adds account name validation and applies it during endpoint URI creation.
tools/Azure.Mcp.Tools.Storage/tests/Azure.Mcp.Tools.Storage.UnitTests/Services/StorageServiceValidateAccountNameTests.cs New unit tests for the account-name validation behavior.
servers/Azure.Mcp.Server/changelog-entries/1775486642509.yaml Documents the storage account name validation change as a bug fix.

Comment thread tools/Azure.Mcp.Tools.Storage/src/Services/StorageService.cs
Comment thread tools/Azure.Mcp.Tools.Storage/src/Services/StorageService.cs
Comment thread tools/Azure.Mcp.Tools.Storage/src/Services/StorageService.cs
Comment thread tools/Azure.Mcp.Tools.Storage/src/Services/StorageService.cs
@xiangyan99 xiangyan99 merged commit 03b6478 into release/azure/2.x Apr 6, 2026
29 checks passed
@xiangyan99 xiangyan99 deleted the storage_validation_2.x branch April 6, 2026 17:41
@github-project-automation github-project-automation Bot moved this from Untriaged to Done in Azure MCP Server Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants