compute_vm_create: Update default VM size from Standard_DS1_v2 to Standard_D2s_v5#2415
Conversation
… commands and documentation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates Azure Compute tool defaults to use a newer VM size and fixes option parsing so vmss update can accept capacity and related tri-state flags.
Changes:
- Change default VM size for
vm create/vmss createfromStandard_DS1_v2toStandard_D2s_v5across service logic, tests, and docs. - Fix VMSS update option typing by making
--capacity,--overprovision, and--enable-auto-os-upgradenullable to distinguish “not provided” vs “set”. - Add changelog entries and update server docs/e2e prompts to reflect the new defaults.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.Compute/tests/Azure.Mcp.Tools.Compute.UnitTests/Vmss/VmssUpdateCommandTests.cs | Adds a new validation case for --capacity in vmss update. |
| tools/Azure.Mcp.Tools.Compute/tests/Azure.Mcp.Tools.Compute.UnitTests/Vmss/VmssCreateCommandTests.cs | Updates expected VMSS default size to Standard_D2s_v5. |
| tools/Azure.Mcp.Tools.Compute/tests/Azure.Mcp.Tools.Compute.UnitTests/Vm/VmCreateCommandTests.cs | Updates expected VM default size to Standard_D2s_v5. |
| tools/Azure.Mcp.Tools.Compute/tests/Azure.Mcp.Tools.Compute.LiveTests/ComputeCommandTests.cs | Updates live test assertions for VM size. |
| tools/Azure.Mcp.Tools.Compute/src/Services/ComputeService.cs | Changes default VM size constant and related comments. |
| tools/Azure.Mcp.Tools.Compute/src/Options/ComputeOptionDefinitions.cs | Updates help text and makes VMSS update options nullable. |
| tools/Azure.Mcp.Tools.Compute/src/ComputeSetup.cs | Updates tool description default-size text. |
| tools/Azure.Mcp.Tools.Compute/src/Commands/Vmss/VmssCreateCommand.cs | Updates command description default-size text. |
| tools/Azure.Mcp.Tools.Compute/src/Commands/Vm/VmCreateCommand.cs | Updates command description default-size text. |
| servers/Azure.Mcp.Server/docs/e2eTestPrompts.md | Updates e2e prompt to the new default size. |
| servers/Azure.Mcp.Server/docs/azmcp-commands.md | Updates docs for default size for VM and VMSS create. |
| servers/Azure.Mcp.Server/changelog-entries/1776182026573.yaml | Adds changelog entry for VMSS update option fix. |
| servers/Azure.Mcp.Server/changelog-entries/1775768065287.yaml | Adds changelog entry for default VM size change. |
| eng/tools/ToolDescriptionEvaluator/prompts/namespace-tools.json | Updates evaluator prompt tool description default-size text. |
jongio
left a comment
There was a problem hiding this comment.
Heads up: the PR description says "Standard_DS2_v2" but the actual change is to Standard_D2s_v5 - looks like a typo that could confuse reviewers.
The option type fix (Option<int> to Option<int?> and Option<bool> to Option<bool?>) is correct - the service layer already expected nullable types, and non-nullable options default to 0/false making it impossible to distinguish "not provided" from "explicitly set to default." Good catch.
The Copilot bot already flagged the missing test cases for --overprovision and --enable-auto-os-upgrade - that's worth addressing since the changelog claims all three options are fixed.
…vmsize # Conflicts: # tools/Azure.Mcp.Tools.Compute/tests/Azure.Mcp.Tools.Compute.LiveTests/ComputeCommandTests.cs
…ndard_D2s_v5 (microsoft#2415) * Update default VM size from Standard_DS1_v2 to Standard_D2s_v5 across commands and documentation * Address PR review comments: fix wording, changelog, and remove vmss update scope --------- Co-authored-by: Haider Agha <Haider.Agha@microsoft.com>
What does this PR do?
This PR changes the default size of VM and VMSS creation from Standard_DS1_v2 to Standard_D2s_v5
This PR will also fixes bugs relating to VMSS update options binding.
GitHub issue number?
#2244
Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline