Skip to content

Redirect writing errors to stdio to stderr #2559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
conniey merged 4 commits into from
May 1, 2026
Merged

Redirect writing errors to stdio to stderr #2559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad4f2c4
Write to Error output.
conniey May 1, 2026
a21624e
Add changelog entry.
conniey May 1, 2026
67a8c9d
Potential fix for pull request finding
conniey May 1, 2026
4fcbd34
Apply getType().FullName
conniey May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions core/Microsoft.Mcp.Core/src/Services/Azure/Authentication/WindowHandleProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,19 @@ public static IntPtr GetWindowHandle()
try
{
IntPtr display = XOpenDisplay(":1");
Console.WriteLine(display == IntPtr.Zero

// Do not write to standard output because it is interpreted as a JSON RPC response
// from the MCP server. Instead, write to standard error for diagnostics.
Console.Error.WriteLine(display == IntPtr.Zero
? "No X display available. Running in headless mode."
: "X display is available.");
Comment thread
conniey marked this conversation as resolved.
return display;
}
catch (Exception)
catch (Exception exception)
{
// X11 display detection failed; running in headless mode.
// Avoid logging exception details to console to prevent information disclosure.
Console.ForegroundColor = ConsoleColor.Red;
Console.WriteLine($"Failed to detect X display. Running in headless mode. Exception type: {typeof(Exception).FullName}");
Console.ResetColor();
Console.Error.WriteLine($"Failed to detect X display. Running in headless mode. Exception type: {exception.GetType().FullName}");
}
}

Expand Down
3 changes: 3 additions & 0 deletions servers/Azure.Mcp.Server/changelog-entries/1777662676190.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
changes:
- section: "Bugs Fixed"
description: "Fix issue where writing exception to stdout is interpreted as JSON RPC response."