Skip to content

Remove App Lens microsoft.web/sites kind gate and support all site kinds #2596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
+16 −28
Open

Remove App Lens microsoft.web/sites kind gate and support all site kinds #2596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cd33e34
Initial plan
Copilot May 6, 2026
55f8567
Remove App Lens web site kind restriction
Copilot May 6, 2026
89033f4
Remove unnecessary discard in AppLens support check
Copilot May 6, 2026
c66628d
Simplify AppLens resource support check signature
Copilot May 6, 2026
c58f4b3
Simplify AppLens supported type check using shared list
Copilot May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions tools/Azure.Mcp.Tools.AppLens/src/Services/AppLensService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ internal async Task<FindResourceIdResult> FindResourceAsync(

// Filter to supported resource types
var supportedResults = filteredResults
.Where(r => IsResourceTypeSupported(r.ResourceType, r.ResourceKind))
.Where(r => IsResourceTypeSupported(r.ResourceType))
.ToImmutableArray();
Comment thread
tmeschter marked this conversation as resolved.

if (supportedResults.Length == 0)
Expand Down Expand Up @@ -255,19 +255,11 @@ private async Task<ImmutableArray<AppLensArgQueryResult>> ExecuteArgQueryAsync(
}

/// <summary>
/// Checks whether a resource type (and optionally kind) is supported by AppLens diagnostics.
/// Checks whether a resource type is supported by AppLens diagnostics.
/// </summary>
internal static bool IsResourceTypeSupported(string resourceType, string resourceKind)
internal static bool IsResourceTypeSupported(string resourceType)
{
if (resourceType.Equals("microsoft.web/sites", StringComparison.OrdinalIgnoreCase))
{
return resourceKind.Equals("app", StringComparison.OrdinalIgnoreCase)
|| resourceKind.Equals("linux", StringComparison.OrdinalIgnoreCase)
|| resourceKind.Equals("functionapp", StringComparison.OrdinalIgnoreCase);
}

return resourceType.Equals("microsoft.containerservice/managedclusters", StringComparison.OrdinalIgnoreCase)
|| resourceType.Equals("microsoft.apimanagement/service", StringComparison.OrdinalIgnoreCase);
return SupportedResourceTypes().Contains(resourceType, StringComparer.OrdinalIgnoreCase);
}

/// <summary>
Expand Down
28 changes: 12 additions & 16 deletions ....AppLens/tests/Azure.Mcp.Tools.AppLens.UnitTests/Resource/ResourceDiagnoseCommandTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,24 +414,20 @@ await ExecuteCommandAsync(
}

[Theory]
[InlineData("microsoft.web/sites", "app", true)]
[InlineData("microsoft.web/sites", "linux", true)]
[InlineData("microsoft.web/sites", "functionapp", true)]
[InlineData("Microsoft.Web/Sites", "App", true)]
[InlineData("MICROSOFT.WEB/SITES", "APP", true)]
[InlineData("microsoft.containerservice/managedclusters", "", true)]
[InlineData("Microsoft.ContainerService/managedClusters", "", true)]
[InlineData("microsoft.apimanagement/service", "", true)]
[InlineData("Microsoft.ApiManagement/service", "", true)]
[InlineData("microsoft.web/sites", "container", false)]
[InlineData("microsoft.web/sites", "", false)]
[InlineData("microsoft.compute/virtualmachines", "", false)]
[InlineData("microsoft.storage/storageaccounts", "", false)]
[InlineData("microsoft.sql/servers", "", false)]
public void IsResourceTypeSupported_ReturnsCorrectResult(string resourceType, string resourceKind, bool expected)
[InlineData("microsoft.web/sites", true)]
[InlineData("Microsoft.Web/Sites", true)]
[InlineData("MICROSOFT.WEB/SITES", true)]
[InlineData("microsoft.containerservice/managedclusters", true)]
[InlineData("Microsoft.ContainerService/managedClusters", true)]
[InlineData("microsoft.apimanagement/service", true)]
[InlineData("Microsoft.ApiManagement/service", true)]
[InlineData("microsoft.compute/virtualmachines", false)]
[InlineData("microsoft.storage/storageaccounts", false)]
[InlineData("microsoft.sql/servers", false)]
public void IsResourceTypeSupported_ReturnsCorrectResult(string resourceType, bool expected)
{
// Act
var result = AppLensService.IsResourceTypeSupported(resourceType, resourceKind);
var result = AppLensService.IsResourceTypeSupported(resourceType);

// Assert
Assert.Equal(expected, result);
Expand Down