Fix Compute Tools Issues#2687
Merged
Merged
Conversation
- COMP-02: VmDeleteCommand now uses DeleteVmAsync bool return to report 'not found' instead of always reporting success - COMP-03: Clarify --user-data requires Base64-encoded content; ARM API requires this format (docs/description update only) - COMP-04: vm/vmss update now correctly clears tags when --tags '' is passed; fix comma-separated tag delimiter mismatch in docs vs impl - COMP-06: DetermineOsType uses word-boundary token matching to avoid false positives (twin-ubuntu) and false negatives (VS Windows images like vs-2022-comm-latest-win11-n-gen2)
alzimmermsft
approved these changes
May 20, 2026
g2vinay
requested review from
JasonYeMSFT,
chidozieononiwu,
hallipr,
jongio,
joshfree,
srnagar and
vukelich
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes multiple correctness issues in the Compute toolchain around VM/VMSS command behavior (delete not-found reporting, tag clearing semantics, and OS type detection from image identifiers), and adds/updates tests + documentation to reflect the corrected behavior.
Changes:
- Update
vm deleteto surface a “not found” message when the VM doesn’t exist (while keeping the operation idempotent / HTTP 200). - Make
vm update/vmss updatetreat--tags ''(and now bare--tags) as “clear all tags”, and align tag delimiter documentation with the implementation. - Improve
DetermineOsTypeimage matching to avoid false positives (e.g., “twin-ubuntu”) and correctly identify Windows Visual Studio images; add unit tests.
Invoking Livetests
Copilot submitted PRs are not trustworthy by default. Users with write access to the repo need to validate the contents of this PR before leaving a comment with the text /azp run mcp - pullrequest - live. This will trigger the necessary livetest workflows to complete required validation.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.Compute/tests/Azure.Mcp.Tools.Compute.Tests/Vmss/VmssUpdateCommandTests.cs | Adds test coverage for clearing VMSS tags via bare --tags. |
| tools/Azure.Mcp.Tools.Compute/tests/Azure.Mcp.Tools.Compute.Tests/Vm/VmUpdateCommandTests.cs | Adds tests for user-data pass-through and tag clearing semantics. |
| tools/Azure.Mcp.Tools.Compute/tests/Azure.Mcp.Tools.Compute.Tests/Vm/VmDeleteCommandTests.cs | Updates delete-not-found expectations (message + Success flag). |
| tools/Azure.Mcp.Tools.Compute/tests/Azure.Mcp.Tools.Compute.Tests/ComputeUtilitiesTests.cs | New unit tests for improved OS type detection. |
| tools/Azure.Mcp.Tools.Compute/src/Utilities/ComputeUtilities.cs | Refines OS detection logic to use token-based matching. |
| tools/Azure.Mcp.Tools.Compute/src/Services/ComputeService.cs | Implements “empty string clears tags” behavior for VM and VMSS patch operations. |
| tools/Azure.Mcp.Tools.Compute/src/Options/ComputeOptionDefinitions.cs | Updates tags/user-data option descriptions; changes --tags arity to allow bare option usage. |
| tools/Azure.Mcp.Tools.Compute/src/Commands/Vmss/VmssUpdateCommand.cs | Treats bare --tags as an explicit clear request during validation/binding. |
| tools/Azure.Mcp.Tools.Compute/src/Commands/Vm/VmUpdateCommand.cs | Same as VMSS: validation/binding recognizes explicit “clear tags”. |
| tools/Azure.Mcp.Tools.Compute/src/Commands/Vm/VmDeleteCommand.cs | Uses service return value to shape message and Success flag. |
| servers/Azure.Mcp.Server/docs/azmcp-commands.md | Updates VM update parameter docs (tags delimiter + user-data details). |
| servers/Azure.Mcp.Server/changelog-entries/1779264486206.yaml | Adds a changelog entry describing the bug fixes. |
haagha
suggested changes
May 28, 2026
Contributor
haagha
left a comment
haagha
left a comment
There was a problem hiding this comment.
VMSS delete has the same behaviour - can we change that too?
github-project-automation
Bot
moved this from Untriaged
to In Progress
in Azure MCP Server
alzimmermsft
approved these changes
May 28, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed multiple bugs in Compute VM/VMSS commands:
-
vm deletenow correctly reports 'not found' when the target VM does not exist instead of always reporting success.-
vm updateandvmss updatenow correctly clear all tags when--tags ''is passed; fixed comma-separated tag delimiter mismatch between documentation and implementation.-
DetermineOsTypenow uses word-boundary token matching: no longer misidentifies images with 'win' mid-word (e.g., 'twin-ubuntu') as Windows.