Skip to content

Update Container App Commands to accept tenant parameter#2702

Merged
msalaman merged 5 commits into
mainfrom
masalama/tenantcontainerapp
May 21, 2026
Merged

Update Container App Commands to accept tenant parameter#2702
msalaman merged 5 commits into
mainfrom
masalama/tenantcontainerapp

Conversation

@msalaman
Copy link
Copy Markdown
Contributor

@msalaman msalaman commented May 21, 2026

What does this PR do?

Update the container app command to accept tenant parameter, which would be useful for multi-tenant scenarios

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR wires the existing global --tenant option through the Container Apps “list” command path so Container Apps can be queried in multi-tenant scenarios.

Changes:

  • Add an optional tenant parameter to IContainerAppsService.ListContainerApps and its implementation.
  • Pass options.Tenant from ContainerAppListCommand into the service call.
  • Update the list command unit tests to match the updated service method signature.
## Invoking Livetests

Copilot submitted PRs are not trustworthy by default. Users with `write` access to the repo need to validate the contents of this PR before leaving a comment with the text `/azp run mcp - pullrequest - live`. This will trigger the necessary livetest workflows to complete required validation.
Show a summary per file
File Description
tools/Azure.Mcp.Tools.ContainerApps/src/Services/IContainerAppsService.cs Extends the Container Apps service contract to accept an optional tenant.
tools/Azure.Mcp.Tools.ContainerApps/src/Services/ContainerAppsService.cs Threads the tenant through to the shared resource query helper.
tools/Azure.Mcp.Tools.ContainerApps/src/Commands/ContainerApp/ContainerAppListCommand.cs Passes the bound --tenant value into the service call.
tools/Azure.Mcp.Tools.ContainerApps/tests/Azure.Mcp.Tools.ContainerApps.Tests/ContainerApp/ContainerAppListCommandTests.cs Updates mocks to align with the new service method signature.

Copilot's findings

  • Files reviewed: 6/6 changed files
  • Comments generated: 1

Comment thread servers/Azure.Mcp.Server/docs/azmcp-commands.md Outdated
msalaman and others added 2 commits May 21, 2026 14:40
Co-authored-by: Alan Zimmer <48699787+alzimmermsft@users.noreply.github.com>
Removed redundant examples for listing Azure Container Apps.
@github-project-automation github-project-automation Bot moved this from Untriaged to In Progress in Azure MCP Server May 21, 2026
@msalaman msalaman merged commit b148716 into main May 21, 2026
15 checks passed
@msalaman msalaman deleted the masalama/tenantcontainerapp branch May 21, 2026 20:18
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Azure MCP Server May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants