Skip to content

Set SslMode to Require in all PostgreSQL tools#2749

Merged
vcolin7 merged 3 commits into
mainfrom
fix/postgres-connection
May 27, 2026
Merged

Set SslMode to Require in all PostgreSQL tools#2749
vcolin7 merged 3 commits into
mainfrom
fix/postgres-connection

Conversation

@vcolin7
Copy link
Copy Markdown
Contributor

@vcolin7 vcolin7 commented May 27, 2026

What does this PR do?

Update the SslMode in PostgreSQL connection settings to Require instead of the default Prefer, ensuring consistency with other database tools like those in the MySQL namespace.

GitHub issue number?

#468

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

Copilot AI review requested due to automatic review settings May 27, 2026 20:27
@vcolin7 vcolin7 requested review from a team, kk-src and xiangyan99 as code owners May 27, 2026 20:27
@vcolin7 vcolin7 requested review from RickWinter and g2vinay May 27, 2026 20:27
@github-actions github-actions Bot added the tools-Postgres PostgreSQL label May 27, 2026
@vcolin7 vcolin7 force-pushed the fix/postgres-connection branch from 5c05f58 to 946f6f4 Compare May 27, 2026 20:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates PostgreSQL connection string construction to require SSL explicitly, aligning the Postgres service behavior with similar database tooling such as MySQL.

Changes:

  • Sets SslMode to Require when building Postgres connection strings.
  • Adds an Azure MCP Server changelog entry for the SSL mode change.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tools/Azure.Mcp.Tools.Postgres/src/Services/PostgresService.cs Adds explicit SslMode.Require to Postgres connection string construction.
servers/Azure.Mcp.Server/CHANGELOG.md Documents the PostgreSQL SSL mode update under unreleased changes.

Comment thread tools/Azure.Mcp.Tools.Postgres/src/Services/PostgresService.cs
@vcolin7 vcolin7 changed the title Set SslMode to Require in PostgresService Set SslMode to Require in all PostgreSQL tools May 27, 2026
@vcolin7 vcolin7 enabled auto-merge (squash) May 27, 2026 20:58
@github-project-automation github-project-automation Bot moved this from Untriaged to In Progress in Azure MCP Server May 27, 2026
@vcolin7 vcolin7 merged commit a6274b7 into main May 27, 2026
15 checks passed
@vcolin7 vcolin7 deleted the fix/postgres-connection branch May 27, 2026 21:24
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Azure MCP Server May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools-Postgres PostgreSQL

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants