Add azmcp-keyvault-admin-settings-get for KeyVault.Administration#358
Merged
JonathanCrd merged 25 commits intomicrosoft:mainfrom Sep 23, 2025
Merged
Conversation
jongio
requested changes
Sep 8, 2025
github-project-automation
Bot
moved this from Untriaged
to In Progress
in Azure MCP Server
JonathanCrd
requested review from
fanyang-mono,
hallipr,
msalaman,
sandeep-sen,
vukelich and
wbreza
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the first tool for KeyVault Administration (Data Plane): azmcp-keyvault-admin-settings-get. The command retrieves Key Vault administration settings including purge protection state and soft delete retention days using the Azure.Security.KeyVault.Administration SDK.
- Implements the
azmcp-keyvault-admin-settings-getcommand for retrieving Key Vault administration settings - Extends KeyVaultService with new data plane administration functionality
- Adds comprehensive test coverage for the new admin settings command
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| AdminSettingsGetCommandTests.cs | Unit tests for the new admin settings get command |
| KeyVaultService.cs | Extended service with GetVaultSettings method using Administration SDK |
| IKeyVaultService.cs | Interface extension with new method and VaultSettings record |
| AdminSettingsGetOptions.cs | Options class for admin settings command |
| KeyVaultSetup.cs | Command registration for admin settings functionality |
| KeyVaultJsonContext.cs | JSON serialization context for VaultSettings |
| AdminSettingsGetCommand.cs | Implementation of the admin settings get command |
| Azure.Mcp.Tools.KeyVault.csproj | Added Azure.Security.KeyVault.Administration package reference |
| CHANGELOG.md | Documentation of the new feature |
| Directory.Packages.props | Package version management for the new dependency |
vcolin7
reviewed
Sep 9, 2025
vcolin7
reviewed
Sep 9, 2025
vcolin7
reviewed
Sep 9, 2025
vcolin7
reviewed
Sep 9, 2025
vcolin7
reviewed
Sep 9, 2025
vcolin7
reviewed
Sep 9, 2025
vcolin7
reviewed
Sep 9, 2025
vcolin7
reviewed
Sep 9, 2025
jongio
requested changes
Sep 11, 2025
…d-admin-get-settings
…d-admin-get-settings
jongio
requested changes
Sep 23, 2025
vcolin7
reviewed
Sep 23, 2025
jongio
approved these changes
Sep 23, 2025
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Sep 27, 2025
…icrosoft#358) * Added Azure.Security.KeyVault.Administration to project * Added command * Added tests * Update CHANGELOGs * dotnet format * Addressed comments in PR review * Cleaned up unused using statement. * Update README.md and azmcp-commands.md * Add prompts for retrieving key vault administration settings * Addressed comments and applied code suggestions * Return the settings as a dictionary and use SDK types * Rename TenantID * Add live tests * dotnet format * Add keyVaultAdminRoleDefinition * Use Managed HSM URI and improve descriptions * Fix tests * Use updated pattern * addressing comments * dotnet format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the first tool for KeyVault Administration (Data Plane):
azmcp-keyvault-admin-settings-getGitHub issue number?
Resolves #308
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentation/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline