Skip to content

New Tool: List Event Grid Subscription#364

Merged
anannya03 merged 19 commits intomicrosoft:mainfrom
anannya03:list-event-subscription
Sep 17, 2025
Merged

New Tool: List Event Grid Subscription#364
anannya03 merged 19 commits intomicrosoft:mainfrom
anannya03:list-event-subscription

Conversation

@anannya03
Copy link
Copy Markdown
Contributor

@anannya03 anannya03 commented Sep 8, 2025

What does this PR do?

This PR introduces a new tool azmcp-eventgrid-subscription-list that allows users to list all Event Grid subscripts within a given subscription/topic. It's also possible to filter based on resource group and location.

“List all Event Grid subscriptions in my subscription”

GitHub issue number?

#299

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
    • Spelling check passes: .\eng\common\spelling\Invoke-Cspell.ps1
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated README.md documentation
    • Updated command list in /docs/azmcp-commands.md
    • Updated test prompts in /docs/e2eTestPrompts.md
    • [] For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
  • 👉 For Community (non-Azure team member) PRs:
    • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
    • Manual tests run: added comment /azp run azure - mcp to run Live Test Pipeline

Comment thread tools/Azure.Mcp.Tools.EventGrid/src/Options/EventGridOptionDefinitions.cs Outdated
@anannya03 anannya03 force-pushed the list-event-subscription branch from 222acc9 to f7160c8 Compare September 9, 2025 14:19
@anannya03 anannya03 marked this pull request as ready for review September 10, 2025 03:27
Copilot AI review requested due to automatic review settings September 10, 2025 03:27
@anannya03 anannya03 requested a review from a team as a code owner September 10, 2025 03:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new EventGrid subscription listing tool to the Azure MCP Server, enabling users to discover and filter Event Grid subscriptions across their Azure resources.

  • Adds azmcp_eventgrid_subscription_list command with comprehensive filtering capabilities
  • Implements subscription retrieval from both custom topics and system topics
  • Provides detailed subscription information including endpoints, filters, and retry policies

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
SubscriptionListCommandTests.cs New unit test file with comprehensive test coverage for subscription listing scenarios
SubscriptionListCommand.cs New command implementation for listing Event Grid subscriptions with filtering options
EventGridService.cs Extended service with subscription retrieval logic for custom and system topics
IEventGridService.cs Added interface method for subscription operations
EventGridSubscriptionInfo.cs New model representing Event Grid subscription data
SubscriptionListOptions.cs New options class for subscription list command parameters
EventGridOptionDefinitions.cs Added topic name and location option definitions
Various documentation files Updated with new command information and examples

Comment thread tools/Azure.Mcp.Tools.EventGrid/src/Services/EventGridService.cs Outdated
Comment thread tools/Azure.Mcp.Tools.EventGrid/src/Services/EventGridService.cs Outdated
Comment thread tools/Azure.Mcp.Tools.EventGrid/src/Services/EventGridService.cs Outdated
Comment thread tools/Azure.Mcp.Tools.EventGrid/src/Services/EventGridService.cs Outdated
@anannya03 anannya03 force-pushed the list-event-subscription branch from 627226d to f44b964 Compare September 10, 2025 14:08
Comment thread docs/e2eTestPrompts.md
Comment thread docs/e2eTestPrompts.md
Comment thread servers/Azure.Mcp.Server/README.md Outdated
Comment thread tools/Azure.Mcp.Tools.EventGrid/src/Services/EventGridService.cs
Comment thread tools/Azure.Mcp.Tools.EventGrid/src/GlobalUsings.cs Outdated
Comment thread tools/Azure.Mcp.Tools.EventGrid/src/Commands/Topic/TopicListCommand.cs Outdated
Comment thread tools/Azure.Mcp.Tools.EventGrid/src/Services/EventGridService.cs Outdated
Comment thread tools/Azure.Mcp.Tools.EventGrid/src/Services/EventGridService.cs Outdated
Comment thread tools/Azure.Mcp.Tools.EventGrid/src/Services/EventGridService.cs Outdated
Comment thread tools/Azure.Mcp.Tools.EventGrid/src/Services/EventGridService.cs
Comment thread tools/Azure.Mcp.Tools.EventGrid/src/Services/EventGridService.cs Outdated
Comment thread tools/Azure.Mcp.Tools.EventGrid/src/Commands/Topic/TopicListCommand.cs Outdated
Comment thread tools/Azure.Mcp.Tools.EventGrid/src/Options/EventGridOptionDefinitions.cs Outdated
Comment thread tools/Azure.Mcp.Tools.EventGrid/src/Services/EventGridService.cs
@github-project-automation github-project-automation Bot moved this from Untriaged to In Progress in Azure MCP Server Sep 15, 2025
@anannya03 anannya03 force-pushed the list-event-subscription branch from bff5307 to 76083a0 Compare September 16, 2025 06:27
@joshfree joshfree added this to the 2025-09 milestone Sep 16, 2025
@anannya03 anannya03 force-pushed the list-event-subscription branch from 5b868f2 to 6a1337b Compare September 17, 2025 04:01
@anannya03 anannya03 force-pushed the list-event-subscription branch from 6a1337b to 75d73bf Compare September 17, 2025 20:49
Comment thread .vscode/mcp.json Outdated
@anannya03 anannya03 merged commit beb4153 into microsoft:main Sep 17, 2025
28 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Azure MCP Server Sep 17, 2025
colbytimm pushed a commit to colbytimm/microsoft-mcp that referenced this pull request Sep 27, 2025
* Resolved merge conflict- 1

* Resolved merge conflict- 2

* Resolved merge conflict- 3

* Resolved merge conflict- 4

* Merge conflict 2

* Resolved merge conflict- 5

* Removed unnecessary line from CHANGELOG.md

* Made topic or subscription mandatory

* dotnet format

* Resolved merge conflict- 6

* Resolved merge conflict- 7

* Dotnet format

* AccountGetCommandTest change

* Used validate override

* Fixed the validation logic

* Rebased it to match the new structure

* Fixed the changes after rebase

* Addressed review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants