Add telemetry for bestpractices command parameters#375
Merged
fanyang-mono merged 4 commits intomicrosoft:mainfrom Sep 9, 2025
Merged
Add telemetry for bestpractices command parameters#375fanyang-mono merged 4 commits intomicrosoft:mainfrom
fanyang-mono merged 4 commits intomicrosoft:mainfrom
Conversation
fanyang-mono
requested review from
a team,
conniey and
g2vinay
as code owners
fanyang-mono
requested review from
hallipr,
msalaman,
tmeschter,
vukelich,
wbreza and
xiangyan99
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds telemetry support to the BestPracticesCommand by logging the resource and action parameter values when the command executes successfully. The change adds activity tags to track usage patterns of the best practices tool.
- Adds telemetry tracking for resource and action parameters
- Includes new import for telemetry services
- Tags are only added on successful execution after validation
jongio
approved these changes
Sep 9, 2025
github-project-automation
Bot
moved this from Untriaged
to In Progress
in Azure MCP Server
jongio
approved these changes
Sep 9, 2025
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Sep 27, 2025
* Add telemetry for bestpractices command parameters * Update CHANGELOG * Address review feedback * Fix formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add telemetry to log parameter values for bestpractices tool. Note that only valid values will be logged.
GitHub issue number?
N/A
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentation/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline