Add AKS tool for getting nodepools#394
Merged
feiskyer merged 1 commit intomicrosoft:mainfrom Sep 12, 2025
Merged
Conversation
feiskyer
requested review from
JasonYeMSFT,
KarishmaGhiya,
alzimmermsft,
Copilot,
jongio,
sandeep-sen,
tmeschter and
xiangyan99
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new AKS tool for getting detailed information about a specific node pool in an Azure Kubernetes Service cluster. It provides comprehensive functionality to retrieve node pool configuration and status details.
- Adds
NodepoolGetCommandwith validation and error handling for retrieving individual node pool details - Implements
GetNodePoolmethod inAksServicewith caching support and proper Azure SDK integration - Includes comprehensive unit and live tests covering successful retrieval, validation, and error scenarios
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| NodepoolGetCommandTests.cs (UnitTests) | Unit tests for the nodepool get command including parameter validation and error handling |
| NodepoolGetCommandTests.cs (LiveTests) | Live integration tests against real Azure resources |
| IAksService.cs | Interface extension adding GetNodePool method signature |
| AksService.cs | Implementation of GetNodePool with caching and Azure SDK calls |
| NodepoolGetOptions.cs | Options class defining required parameters for the get command |
| AksOptionDefinitions.cs | Added nodepool name option definition |
| NodepoolGetCommand.cs | Main command implementation with validation and execution logic |
| AksJsonContext.cs | JSON serialization context update for the new result type |
| AksSetup.cs | Registration of the new command in the command hierarchy |
| README.md | Documentation update with example usage |
| CHANGELOG.md | Release notes entry |
| e2eTestPrompts.md | End-to-end test prompts for the new functionality |
| azmcp-commands.md | Command documentation update |
jongio
approved these changes
Sep 11, 2025
github-project-automation
Bot
moved this from Untriaged
to In Progress
in Azure MCP Server
feiskyer
force-pushed
the
aks-nodepool-gets
branch
from
eef0bb4 to
c4a625a
Compare
jongio
approved these changes
Sep 11, 2025
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Sep 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add AKS tool for getting nodepools
GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentation/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline