Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates tool metadata across multiple MCP commands to explicitly set the Secret property, marking the secret_create tool as requiring secret handling while ensuring other tools are properly configured with complete metadata.
- Marks the KeyVault
secret_createcommand withSecret = trueto enable proper secret handling - Standardizes tool metadata across all commands by explicitly setting all metadata properties
- Removes a test case for the secret creation functionality
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/Fabric.Mcp.Tools.PublicApi/src/Commands/PublicApis/ListWorkloadsCommand.cs | Expands metadata to include all properties with Secret = false |
| tools/Fabric.Mcp.Tools.PublicApi/src/Commands/PublicApis/GetWorkloadApisCommand.cs | Expands metadata to include all properties with Secret = false |
| tools/Fabric.Mcp.Tools.PublicApi/src/Commands/PublicApis/GetPlatformApisCommand.cs | Expands metadata to include all properties with Secret = false |
| tools/Fabric.Mcp.Tools.PublicApi/src/Commands/BestPractices/GetWorkloadDefinitionCommand.cs | Expands metadata to include all properties with Secret = false |
| tools/Fabric.Mcp.Tools.PublicApi/src/Commands/BestPractices/GetExamplesCommand.cs | Expands metadata to include all properties with Secret = false |
| tools/Fabric.Mcp.Tools.PublicApi/src/Commands/BestPractices/GetBestPracticesCommand.cs | Expands metadata to include all properties with Secret = false |
| tools/Azure.Mcp.Tools.ResourceHealth/src/Commands/ServiceHealthEvents/ServiceHealthEventsListCommand.cs | Expands metadata to include all properties with Secret = false |
| tools/Azure.Mcp.Tools.KeyVault/tests/Azure.Mcp.Tools.KeyVault.LiveTests/KeyVaultCommandTests.cs | Removes test case for secret creation functionality |
| tools/Azure.Mcp.Tools.KeyVault/src/Commands/Secret/SecretCreateCommand.cs | Changes Secret = false to Secret = true for secret creation |
| tools/Azure.Mcp.Tools.Extension/src/Commands/AzqrCommand.cs | Expands metadata to include all properties with Secret = false |
| tools/Azure.Mcp.Tools.AzureManagedLustre/src/Commands/FileSystem/Sku/SkuGetCommand.cs | Reorders and adds missing LocalRequired = false property |
| tools/Azure.Mcp.Tools.AppLens/src/Commands/Resource/ResourceDiagnoseCommand.cs | Expands metadata to include all properties with Secret = false |
| tools/Azure.Mcp.Tools.Aks/src/Commands/Nodepool/NodepoolListCommand.cs | Expands metadata to include all properties with Secret = false |
| tools/Azure.Mcp.Tools.Aks/src/Commands/Nodepool/NodepoolGetCommand.cs | Expands metadata to include all properties with Secret = false |
| servers/Azure.Mcp.Server/CHANGELOG.md | Documents the change to mark secret_create tool with secret hint |
| core/Azure.Mcp.Core/src/Areas/Tools/Commands/ToolsListCommand.cs | Expands metadata to include all properties with Secret = false |
| core/Azure.Mcp.Core/src/Areas/Subscription/Commands/SubscriptionListCommand.cs | Expands metadata to include all properties with Secret = false |
| core/Azure.Mcp.Core/src/Areas/Group/Commands/GroupListCommand.cs | Expands metadata to include all properties with Secret = false |
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Sep 27, 2025
* mark secret_create secret * Add tool hints * update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[Provide a clear, concise description of the changes][Any additional context, screenshots, or information that helps reviewers]Marked the secret hint of 'secret_create' tool to true.
GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentation/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline