Skip to content

mark secret_create secret#430

Merged
xiangyan99 merged 3 commits intomainfrom
mark_secret_create_meta
Sep 15, 2025
Merged

mark secret_create secret#430
xiangyan99 merged 3 commits intomainfrom
mark_secret_create_meta

Conversation

@xiangyan99
Copy link
Copy Markdown
Member

What does this PR do?

[Provide a clear, concise description of the changes]

[Any additional context, screenshots, or information that helps reviewers]

Marked the secret hint of 'secret_create' tool to true.

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Updated command list in /docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

@xiangyan99 xiangyan99 marked this pull request as ready for review September 12, 2025 23:26
Copilot AI review requested due to automatic review settings September 12, 2025 23:26
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates tool metadata across multiple MCP commands to explicitly set the Secret property, marking the secret_create tool as requiring secret handling while ensuring other tools are properly configured with complete metadata.

  • Marks the KeyVault secret_create command with Secret = true to enable proper secret handling
  • Standardizes tool metadata across all commands by explicitly setting all metadata properties
  • Removes a test case for the secret creation functionality

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tools/Fabric.Mcp.Tools.PublicApi/src/Commands/PublicApis/ListWorkloadsCommand.cs Expands metadata to include all properties with Secret = false
tools/Fabric.Mcp.Tools.PublicApi/src/Commands/PublicApis/GetWorkloadApisCommand.cs Expands metadata to include all properties with Secret = false
tools/Fabric.Mcp.Tools.PublicApi/src/Commands/PublicApis/GetPlatformApisCommand.cs Expands metadata to include all properties with Secret = false
tools/Fabric.Mcp.Tools.PublicApi/src/Commands/BestPractices/GetWorkloadDefinitionCommand.cs Expands metadata to include all properties with Secret = false
tools/Fabric.Mcp.Tools.PublicApi/src/Commands/BestPractices/GetExamplesCommand.cs Expands metadata to include all properties with Secret = false
tools/Fabric.Mcp.Tools.PublicApi/src/Commands/BestPractices/GetBestPracticesCommand.cs Expands metadata to include all properties with Secret = false
tools/Azure.Mcp.Tools.ResourceHealth/src/Commands/ServiceHealthEvents/ServiceHealthEventsListCommand.cs Expands metadata to include all properties with Secret = false
tools/Azure.Mcp.Tools.KeyVault/tests/Azure.Mcp.Tools.KeyVault.LiveTests/KeyVaultCommandTests.cs Removes test case for secret creation functionality
tools/Azure.Mcp.Tools.KeyVault/src/Commands/Secret/SecretCreateCommand.cs Changes Secret = false to Secret = true for secret creation
tools/Azure.Mcp.Tools.Extension/src/Commands/AzqrCommand.cs Expands metadata to include all properties with Secret = false
tools/Azure.Mcp.Tools.AzureManagedLustre/src/Commands/FileSystem/Sku/SkuGetCommand.cs Reorders and adds missing LocalRequired = false property
tools/Azure.Mcp.Tools.AppLens/src/Commands/Resource/ResourceDiagnoseCommand.cs Expands metadata to include all properties with Secret = false
tools/Azure.Mcp.Tools.Aks/src/Commands/Nodepool/NodepoolListCommand.cs Expands metadata to include all properties with Secret = false
tools/Azure.Mcp.Tools.Aks/src/Commands/Nodepool/NodepoolGetCommand.cs Expands metadata to include all properties with Secret = false
servers/Azure.Mcp.Server/CHANGELOG.md Documents the change to mark secret_create tool with secret hint
core/Azure.Mcp.Core/src/Areas/Tools/Commands/ToolsListCommand.cs Expands metadata to include all properties with Secret = false
core/Azure.Mcp.Core/src/Areas/Subscription/Commands/SubscriptionListCommand.cs Expands metadata to include all properties with Secret = false
core/Azure.Mcp.Core/src/Areas/Group/Commands/GroupListCommand.cs Expands metadata to include all properties with Secret = false

Copy link
Copy Markdown
Contributor

@fanyang-mono fanyang-mono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-project-automation github-project-automation Bot moved this from Untriaged to In Progress in Azure MCP Server Sep 15, 2025
@xiangyan99 xiangyan99 merged commit 06e0fac into main Sep 15, 2025
28 checks passed
@xiangyan99 xiangyan99 deleted the mark_secret_create_meta branch September 15, 2025 18:30
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Azure MCP Server Sep 15, 2025
colbytimm pushed a commit to colbytimm/microsoft-mcp that referenced this pull request Sep 27, 2025
* mark secret_create secret

* Add tool hints

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants