Skip to content

App config options fix#44

Merged
conniey merged 3 commits intomicrosoft:mainfrom
conniey:solution-changes
Aug 27, 2025
Merged

App config options fix#44
conniey merged 3 commits intomicrosoft:mainfrom
conniey:solution-changes

Conversation

@conniey
Copy link
Copy Markdown
Member

@conniey conniey commented Aug 25, 2025

What does this PR do?

  • Passes configuration options to AppConfig client.

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
    • Spelling check passes: .\eng\common\spelling\Invoke-Cspell.ps1
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated README.md documentation
    • Updated command list in /docs/azmcp-commands.md
    • Updated test prompts in /docs/e2eTestPrompts.md
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
  • 👉 For Community (non-Azure team member) PRs:
    • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
    • Manual tests run: added comment /azp run azure - mcp to run Live Test Pipeline

Copilot AI review requested due to automatic review settings August 25, 2025 19:12
@conniey conniey requested review from a team and JonathanCrd as code owners August 25, 2025 19:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restructures the solution file to organize projects into logical subfolders and fixes the Azure App Configuration client configuration by properly passing options to the ConfigurationClient constructor.

  • Organizes projects from a flat structure into hierarchical folders (core, servers, tools with Azure/Template/Fabric subfolders)
  • Fixes AppConfig service to properly pass configuration options to the Azure configuration client

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
AzureMcp.sln Adds solution folders and reorganizes all projects into a hierarchical structure
tools/Azure.Mcp.Tools.AppConfig/src/Services/AppConfigService.cs Fixes ConfigurationClient instantiation to properly pass the options parameter

Comment thread tools/Azure.Mcp.Tools.AppConfig/src/Services/AppConfigService.cs
@conniey conniey changed the title Create subfolders in .sln. App config fix App config fix Aug 25, 2025
@conniey conniey changed the title App config fix App config options fix Aug 25, 2025
Comment thread servers/Azure.Mcp.Server/CHANGELOG.md Outdated
@conniey conniey enabled auto-merge August 25, 2025 20:49
auto-merge was automatically disabled August 27, 2025 19:05

Merge commits are not allowed on this repository

@conniey conniey merged commit 0a55eff into microsoft:main Aug 27, 2025
26 checks passed
@conniey conniey deleted the solution-changes branch August 27, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants