Merge AppConfig key-value list and show into get#505
Merged
alzimmermsft merged 13 commits intomicrosoft:mainfrom Oct 1, 2025
Merged
Merge AppConfig key-value list and show into get#505alzimmermsft merged 13 commits intomicrosoft:mainfrom
alzimmermsft merged 13 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Consolidates the separate key-value list and show commands into a single unified get command for Azure App Configuration, adding filtering capabilities.
- Replaces KeyValueListCommand and KeyValueShowCommand with KeyValueGetCommand supporting both single retrieval and filtered listing.
- Introduces --key-filter and --label-filter options (but service implementation currently ignores them).
- Updates tests, documentation, serialization context, and changelog to reflect the merged command.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| KeyValueShowCommandTests.cs | Removed obsolete show command unit tests. |
| KeyValueListCommandTests.cs | Removed obsolete list command unit tests. |
| KeyValueGetCommandTests.cs | Added unit tests for new unified get command (missing some validation/filter coverage). |
| AppConfigCommandTests.cs | Updated live tests to use new get tool and array-based results. |
| IAppConfigService.cs | Merged list/show service methods into GetKeyValues; removed GetKeyValue. |
| AppConfigService.cs | Implemented merged GetKeyValues logic (currently ignores new filter parameters). |
| KeyValueShowOptions.cs | Removed obsolete options type. |
| KeyValueGetOptions.cs | Added unified options including new filter properties. |
| AppConfigOptionDefinitions.cs | Added key-filter/label-filter options; refactored option declarations. |
| KeyValueShowCommand.cs | Removed obsolete command. |
| KeyValueListCommand.cs | Removed obsolete command. |
| KeyValueGetCommand.cs | Added unified command with validation preventing ambiguous key + key-filter usage. |
| AppConfigJsonContext.cs | Updated JSON context to include new result type and remove old ones. |
| AppConfigSetup.cs | Registered new get command; removed list/show registrations. |
| CHANGELOG.md | Documented breaking change merging commands. |
| e2eTestPrompts.md | Updated prompts to reflect new get command and added filter scenarios. |
| azmcp-commands.md | Updated CLI usage examples for merged command and new filters. |
jongio
approved these changes
Oct 1, 2025
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Dec 8, 2025
* Merge AppConfig key-value list and show into get * Few small fixes * Fix validation * Merge in main * Use new extension to retrieve value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Merges the tools
azmcp_appconfig_kv_listandazmcp_appconfig_kv_showinto a single toolazmcp_appconfig_kv_getwhich can determine whether to list key-value settings based on where--keyis used.Adds two new parameters
--key-filterand--label-filterto disambiguate functionality from--keyand--labelnow that the same tool uses both sets of parameters. If both--keyand--key-filterare passed to the tool it will fail validation, as this is ambiguous on which behavior should be used.GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentation/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts