Return explicit empty subscription list result#508
Merged
JasonYeMSFT merged 2 commits intomicrosoft:mainfrom Sep 24, 2025
Merged
Conversation
JasonYeMSFT
requested review from
JonathanCrd,
Copilot,
jongio,
joshfree,
msalaman,
tmeschter,
vukelich and
xiangyan99
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the SubscriptionListCommand to always return an explicit empty list instead of null when no subscriptions are found, improving consistency for LLM consumers.
- Updates command logic to return empty enumerable instead of null for empty subscription results
- Updates corresponding unit test to verify the new behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| SubscriptionListCommand.cs | Removes null coalescing logic to always return a response result with subscription data |
| SubscriptionListCommandTests.cs | Updates test name and assertion to verify non-null results for empty subscription lists |
alzimmermsft
approved these changes
Sep 19, 2025
JasonYeMSFT
force-pushed
the
chuye/explicit-empty-subscription-list-result
branch
from
ea8d1bf to
b79e660
Compare
alzimmermsft
approved these changes
Sep 24, 2025
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Sep 27, 2025
* Return explicit empty subscription list result * Fix test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR mades the SubscriptionListCommand follow the pattern to coalesce null into empty enumerable for empty subscription list result to avoid confusing the LLM.
GitHub issue number?
#165
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentation/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline