Skip to content

Update openworld destructive hints#510

Merged
xiangyan99 merged 2 commits intomainfrom
update_openworld_destructive_hints
Sep 19, 2025
Merged

Update openworld destructive hints#510
xiangyan99 merged 2 commits intomainfrom
update_openworld_destructive_hints

Conversation

@xiangyan99
Copy link
Copy Markdown
Member

What does this PR do?

[Provide a clear, concise description of the changes]

  • Update the value of OpenWorld - Only tools that interact with the internet set the OpenWorldHint to true.
  • Update the value of Destructive - Create operations are also considered destructive.

[Any additional context, screenshots, or information that helps reviewers]

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Updated command list in /docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR systematically updates the metadata properties for MCP tools to better align with their operational characteristics. The changes ensure that OpenWorld is only set to true for tools that truly interact with external internet resources, and that all create operations are properly marked as destructive.

  • Updates OpenWorld hint from true to false for tools that operate within closed/predictable Azure domains
  • Updates Destructive flag from false to true for create operations to properly reflect their destructive nature
  • Updates documentation comments to clarify the intended usage of these metadata properties

Reviewed Changes

Copilot reviewed 136 out of 136 changed files in this pull request and generated no comments.

File Description
Multiple tool command files Changed OpenWorld from true to false for Azure service commands that don't interact with the internet
Multiple create command files Changed Destructive from false to true for create operations
docs/new-command.md Updated comments to clarify OpenWorld and Destructive property usage

Comment thread docs/new-command.md
@joshfree joshfree added this to the 2025-09 milestone Sep 19, 2025
@joshfree joshfree added the server-Azure.Mcp Azure.Mcp.Server label Sep 19, 2025
@joshfree joshfree moved this from Untriaged to In Progress in Azure MCP Server Sep 19, 2025
@xiangyan99 xiangyan99 merged commit 9243111 into main Sep 19, 2025
48 checks passed
@xiangyan99 xiangyan99 deleted the update_openworld_destructive_hints branch September 19, 2025 17:00
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Azure MCP Server Sep 19, 2025
colbytimm pushed a commit to colbytimm/microsoft-mcp that referenced this pull request Sep 27, 2025
Update the values of OpenWorld & Destructive hints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

server-Azure.Mcp Azure.Mcp.Server

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants