Add validation for postgres query command#518
Merged
Conversation
xiangyan99
requested review from
alzimmermsft,
Copilot,
fanyang-mono,
hallipr,
jairmyree,
jongio,
joshfree and
wbreza
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds query validation for the PostgreSQL database tool to prevent execution of potentially dangerous SQL statements. It implements multiple validation layers to ensure only safe, read-only SELECT queries are executed.
- Adds a new
SqlQueryValidatorclass that enforces strict allow-list validation for SQL queries - Implements validation in
PostgresServicewith comprehensive safety checks for query structure and content - Integrates validation into the
DatabaseQueryCommandto catch unsafe queries early in the request pipeline
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| SqlQueryValidator.cs | New validator class implementing strict allow-list validation for SQL queries |
| PostgresService.cs | Adds ValidateQuerySafety method with comprehensive query validation logic |
| DatabaseQueryCommand.cs | Integrates SqlQueryValidator into the command execution flow |
| PostgresServiceQueryValidationTests.cs | Comprehensive unit tests for query validation functionality |
| PostgresServiceParameterizedQueryTests.cs | Tests focusing on SQL injection prevention through parameterized queries |
| DatabaseQueryCommandTests.cs | Tests for command-level query validation integration |
| CHANGELOG.md | Documents the new validation feature |
xiangyan99
changed the title
xiangyan99
changed the title
…t/mcp into postgres_validate_query
alzimmermsft
approved these changes
Sep 22, 2025
anuchandy
approved these changes
Oct 1, 2025
alzimmermsft
approved these changes
Oct 1, 2025
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[Provide a clear, concise description of the changes]Add validation in postgre query to ensure read only select.
[Any additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]https://github.com/microsoft/mcp-pr/issues/9
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentation/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline