Using ARG query to support Kusto resource read operations#528
Merged
ArthurMa1978 merged 5 commits intomainfrom Sep 23, 2025
Merged
Using ARG query to support Kusto resource read operations#528ArthurMa1978 merged 5 commits intomainfrom
ArthurMa1978 merged 5 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Kusto service implementation to use Azure Resource Graph (ARG) queries instead of direct Azure Resource Manager Kusto API calls, eliminating the dependency on Azure.ResourceManager.Kusto and reducing the MCP agent size by approximately 1.01 MB.
- Replaced direct ARM API calls with Azure Resource Graph queries for Kusto resource operations
- Updated all service methods from synchronous to asynchronous patterns (added "Async" suffix)
- Created new internal data models to replace Azure.ResourceManager.Kusto types
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.Kusto/src/Services/KustoService.cs | Refactored to use ARG queries and async patterns, added new data conversion methods |
| tools/Azure.Mcp.Tools.Kusto/src/Services/IKustoService.cs | Updated interface with async method signatures |
| tools/Azure.Mcp.Tools.Kusto/src/Models/KustoClusterModel.cs | Added new public record for cluster data representation |
| tools/Azure.Mcp.Tools.Kusto/src/Services/Models/*.cs | Added internal data models for JSON deserialization |
| tools/Azure.Mcp.Tools.Kusto/src/Commands/*.cs | Updated all commands to use async service methods |
| tools/Azure.Mcp.Tools.Kusto/tests/Azure.Mcp.Tools.Kusto.UnitTests/*.cs | Updated unit tests to use async method names |
| tools/Azure.Mcp.Tools.Kusto/src/Azure.Mcp.Tools.Kusto.csproj | Removed Azure.ResourceManager.Kusto dependency |
Comments suppressed due to low confidence (1)
tools/Azure.Mcp.Tools.Kusto/src/Services/Models/KustoManagedServiceIdentity.cs:1
- These properties should have setters to support JSON deserialization. Change
{ get; }to{ get; set; }to ensure the JSON deserializer can populate these values.
// Copyright (c) Microsoft Corporation.
alzimmermsft
approved these changes
Sep 22, 2025
Contributor
alzimmermsft
left a comment
There was a problem hiding this comment.
This looks fantastic!
live1206
approved these changes
Sep 23, 2025
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Sep 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR addresses part of the issue tracked in #226 by updating the Kusto tool to eliminate its dependency on Azure.ResourceManager.Kusto.
As a result, it reduces the MCP agent size by approximately 1.01 MB.
GitHub issue number?
#226
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentation/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline