Skip to content

implementation of activitylog tool#601

Closed
BronkHonkyTonk wants to merge 1 commit intomicrosoft:mainfrom
BronkHonkyTonk:masalama/activityLogTool
Closed

implementation of activitylog tool#601
BronkHonkyTonk wants to merge 1 commit intomicrosoft:mainfrom
BronkHonkyTonk:masalama/activityLogTool

Conversation

@BronkHonkyTonk
Copy link
Copy Markdown

@BronkHonkyTonk BronkHonkyTonk commented Sep 27, 2025

What does this PR do?

[Provide a clear, concise description of the changes]

[Any additional context, screenshots, or information that helps reviewers]

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Updated command list in /docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

@jongio
Copy link
Copy Markdown
Contributor

jongio commented Oct 6, 2025

Please have copilot consult with new-command.md to get the implementation right. Thanks!

private readonly ILogger<ActivityLogListCommand> _logger = logger;

// Define options from OptionDefinitions
private readonly Option<string> _resourceNameOption = ActivityLogOptionDefinitions.ResourceName;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use new-command.md with copilot to make sure your PR adheres to those guidelines

@github-project-automation github-project-automation Bot moved this from Untriaged to In Progress in Azure MCP Server Oct 7, 2025
@msalaman msalaman closed this Oct 8, 2025
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Azure MCP Server Oct 8, 2025
@msalaman
Copy link
Copy Markdown
Contributor

msalaman commented Oct 8, 2025

Closing PR with as it's a duplicate of this PR to add activity log command #720

@BronkHonkyTonk
Copy link
Copy Markdown
Author

Tool editor /
Ready
for-image maintainer

2 similar comments
@BronkHonkyTonk
Copy link
Copy Markdown
Author

Tool editor /
Ready
for-image maintainer

@BronkHonkyTonk
Copy link
Copy Markdown
Author

Tool editor /
Ready
for-image maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants