Using ARG query to support AppConfig resource read operations#606
Merged
ArthurMa1978 merged 4 commits intomainfrom Sep 30, 2025
Merged
Using ARG query to support AppConfig resource read operations#606ArthurMa1978 merged 4 commits intomainfrom
ArthurMa1978 merged 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the AppConfig tool to use Azure Resource Graph (ARG) queries instead of direct Azure Resource Manager API calls, eliminating the dependency on Azure.ResourceManager.AppConfiguration and reducing the MCP agent size by approximately 541 KB.
Key changes include:
- Replaced direct ARM API calls with ARG queries for resource discovery
- Added custom data models to handle JSON deserialization from ARG responses
- Updated the service to inherit from
BaseAzureResourceServicefor ARG functionality
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
AppConfigService.cs |
Refactored to use ARG queries and added JSON conversion logic |
AppConfigurationStoreData.cs |
New model for deserializing ARG query responses |
AppConfigurationStoreProperties.cs |
New model for App Configuration store properties |
AppConfigurationStoreEncryptionProperties.cs |
New model for encryption settings |
AppConfigurationKeyVaultProperties.cs |
New model for Key Vault properties |
AppConfigurationAccount.cs |
Updated property types to be nullable |
AppConfigJsonContext.cs |
Added JSON serialization context for new models |
Azure.Mcp.Tools.AppConfig.csproj |
Removed dependency on Azure.ResourceManager.AppConfiguration |
AppConfigCommandTests.cs |
Updated test constructor to include logger dependency |
Directory.Packages.props |
Removed package reference |
CHANGELOG.md |
Documented the refactoring and dependency removal |
.vscode/cspell.json |
Updated spell checker configuration |
alzimmermsft
approved these changes
Sep 29, 2025
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR addresses part of the issue tracked in #226 by updating the AppConfig tool to eliminate its dependency on Azure.ResourceManager.AppConfiguration.
As a result, it reduces the MCP agent size by approximately 541 KB.
GitHub issue number?
#226
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentation/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline