Reducing ambiguity in Key Vault tool selection#608
Merged
vcolin7 merged 11 commits intomicrosoft:mainfrom Sep 30, 2025
Merged
Conversation
vcolin7
added
the
tools-ToolSelection
vcolin7
requested review from
JasonYeMSFT,
alzimmermsft,
conniey,
joshfree,
tmeschter and
xiangyan99
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates Key Vault tool descriptions to reduce ambiguity during tool selection by providing more detailed and specific descriptions. The changes help improve distinction between similar operations (like "get" vs "list") by clearly stating their specific purposes, required parameters, return values, and what they should not be used for.
- Replaced verbose multi-line descriptions with concise single-line descriptions containing operational details
- Added explicit parameter requirements and return value information to tool descriptions
- Included negative descriptions (e.g., "Not for listing multiple secrets") to prevent incorrect tool selection
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| SecretListCommand.cs | Updated description to emphasize listing/enumeration purpose and exclude single secret retrieval |
| SecretGetCommand.cs | Enhanced description with required parameters, return values, and exclusion of listing functionality |
| SecretCreateCommand.cs | Simplified description with required parameters and version handling clarification |
| KeyListCommand.cs | Updated to clarify listing purpose and exclude single key fetching |
| KeyGetCommand.cs | Enhanced with parameter requirements, return values, and exclusion of listing |
| KeyCreateCommand.cs | Detailed description with supported key types, parameters, and return values |
| CertificateListCommand.cs | Updated to emphasize enumeration and exclude single certificate fetching |
| CertificateImportCommand.cs | Condensed multi-line description to single line with all essential details |
| CertificateGetCommand.cs | Enhanced with parameters, return values, and operational exclusions |
| CertificateCreateCommand.cs | Simplified with parameter requirements and return value details |
| tools.json | Updated tool definitions to reflect new descriptions |
| prompts.json | Added additional test prompts for Key Vault operations |
| e2eTestPrompts.md | Added comprehensive test prompts for Key Vault tool validation |
Contributor
|
I'm a bit confused here, doesn't the GIST show that most scores decreased with the description changes in this PR? |
Contributor
Author
@alzimmermsft The main takeaway from the gist is that the changes increased separation (reduced ambiguity) between the first and second choices for most Key Vault tools, even if scores decreased overall. The top choice remained the same in all cases. |
alzimmermsft
approved these changes
Sep 29, 2025
github-project-automation
Bot
moved this from Untriaged
to In Progress
in Azure MCP Server
anannya03
approved these changes
Sep 30, 2025
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Dec 8, 2025
* Updated prompts and tools JSON files * Ran TDE * Updated KeyCreateCommand description * Updated KeyGetCommand description * Updated KeyListCommand description * Updated Key Vault command descriptions * Updated test prompts * Re-ran the evaluation tool * Updated CHANGELOG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the descriptions for Key Vault tools to provide more details and help disambiguate during early tool selection.
These changes caused a better separation between the top choice and the second choice in most cases where both were close enough to be considered ambiguous. Even though most scores saw a slight drop, the top (and correct) choices remained unchanged.
A detailed analysis can be found in this gist.
GitHub issue number?
#252
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentation/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline